add MinEta parameter to HLTSinglet

[kirschen]

Would like to add MinEta parameter to HLTSinglet in order to be able to use it in path compilation (e.g. for SingleForwardJet path proposed by SMP for 2017 menu).

[cmsbuild]

A new Pull Request was created by @kirschen for master.

It involves the following packages:

HLTrigger/HLTfilters

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[kirschen]

@silviodonato @Martin-Grunewald

Should there be any backports done in order to be able to use this in the 2017 menu?

[Martin-Grunewald]

It looks like we'll move to 910pre3 soon, and then there is no need for a backport.

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19095/console Started: 2017/04/11 14:22

[cmsbuild]

+1
Tested at: 0180fd8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18311/19095/summary.html

[cmsbuild]

Comparison job queued.

[silviodonato]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18311/19095/summary.html

Comparison Summary:

• You potentially added 33 lines to the logs
• Reco comparison results: 1630 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1921141
• DQMHistoTests: Total failures: 39310
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1881658
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[silviodonato]

I'm surprised about the "Reco comparison results: 1630 differences found in the comparisons".
This PR should not change anything in the current reco...

[silviodonato]

I see that also PR 18309 gives exactly the same comparison. So I assume everything is fine.
(I tried to run the HLT menu with the two different configurations and I got exactly the same results).

[davidlange6]

+1