CTPPS: pixel dqm #18361

popovvp · 2017-04-14T00:43:52Z

ctpps pixel dqm initial code
to replace PR 18360

cmsbuild · 2017-04-14T00:44:09Z

A new Pull Request was created by @popovvp for master.

It involves the following packages:

DQM/CTPPS

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

dmitrijus · 2017-04-19T12:02:44Z

DQM/CTPPS/plugins/CTPPSPixelDQMSource.cc

+       ID.setRP(rp);
+       string rpd, rpTitle;
+       CTPPSDetId(ID.getRPId()).rpName(rpTitle, CTPPSDetId::nShort);
+       char *cstr2 = new char [rpTitle.length()+1];


This needs to be deleted.

I uploaded the corrected file

why does
yah->SetBinLabel(rp - RPn_first +1, rpTitle.c_str())

not work?

dmitrijus · 2017-04-21T14:04:44Z

You need to resolve the conflict. I can't even starts the tests before you do.

popovvp · 2017-04-21T14:44:02Z

- I corrected conflict on page https://github.com/cms-sw/cmssw/pull/18361/conflicts - push button 'Mark as resolved' But when I login to this page again there are no changes. What I'm doing wrong ?

…

On Fri, 21 Apr 2017, Dmitrijus wrote: You need to resolve the conflict. I can't even starts the tests before you do. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.[AF7xzH8kSjRN3s3RQxtq2Psm88npgG3yks5ryLd-gaJpZM4M9Wf9.gif]

cmsbuild · 2017-04-21T14:45:24Z

Pull request #18361 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

dmitrijus · 2017-04-21T14:47:01Z

+1

cmsbuild · 2017-04-21T14:47:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19322/console Started: 2017/04/21 16:47

cmsbuild · 2017-04-21T14:47:15Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

dmitrijus · 2017-04-21T14:47:20Z

Wait a bit :)

popovvp · 2017-04-21T14:48:37Z

sorry - forgot to commit

cmsbuild · 2017-04-21T18:01:03Z

-1

Tested at: 51e05f2

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
51e05f2
4291aa9
472a23a
14570d3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18361/19322/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18361/19322/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18361/19322/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test TestRunnerPhysicsToolsCondLiteIO had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
51e05f2
4291aa9
472a23a
14570d3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18361/19322/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18361/19322/git-merge-result

cmsbuild · 2017-04-21T18:01:07Z

Comparison job queued.

cmsbuild · 2017-04-21T19:36:15Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18361/19322/summary.html

Comparison Summary:

You potentially added 83 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1677 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1818989
DQMHistoTests: Total failures: 36115
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1782701
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

constexp instead of #define

cmsbuild · 2017-05-03T12:04:12Z

Pull request #18361 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

dmitrijus · 2017-05-03T12:10:41Z

+1

cmsbuild · 2017-05-03T12:10:57Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19544/console Started: 2017/05/03 15:06

cmsbuild · 2017-05-03T12:10:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

cmsbuild · 2017-05-03T14:18:07Z

+1
Tested at: 8c640a8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18361/19544/summary.html

cmsbuild · 2017-05-03T14:18:11Z

Comparison job queued.

cmsbuild · 2017-05-03T16:50:34Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18361/19544/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3397 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1829090
DQMHistoTests: Total failures: 47453
DQMHistoTests: Total nulls: 22
DQMHistoTests: Total successes: 1781435
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

davidlange6 · 2017-05-04T06:49:49Z

+1

davidlange6 · 2017-05-11T11:17:51Z

DQM/CTPPS/python/ctppsPixelDQMSource_cfi.py

+    tagRPixDigi = cms.InputTag("ctppsPixelDigis", ""),
+    tagRPixCluster = cms.InputTag("clusterProd", ""),  
+    RPStatusWord = cms.untracked.uint32(0x8000), # rpots included in readout
+    verbosity = cms.untracked.uint32(1)


Hi @popovvp - this needs to be changed to 0 for production use. Thanks for a quick PR fixing it.

modified -> new PR 18692

ctpps pixel dqm initial code

1dfe3a4

cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 14, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Apr 14, 2017

dmitrijus suggested changes Apr 19, 2017

View reviewed changes

delete tmp allocated char & update

726d256

Merge branch 'master' into ctpps_pixel_dqm4

51e05f2

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Apr 21, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 21, 2017

cmsbuild added tests-rejected and removed tests-started labels Apr 21, 2017

define->constexp (one more)

8c640a8

constexp instead of #define

cmsbuild added dqm-pending pending-signatures tests-pending and removed dqm-approved fully-signed tests-started labels May 3, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 3, 2017

cmsbuild added tests-started and removed tests-pending labels May 3, 2017

cmsbuild added tests-approved and removed tests-started labels May 3, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 3, 2017

cmsbuild added orp-approved and removed orp-pending labels May 4, 2017

cmsbuild merged commit c658e7f into cms-sw:master May 4, 2017

davidlange6 reviewed May 11, 2017

View reviewed changes

popovvp deleted the ctpps_pixel_dqm4 branch July 17, 2017 09:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CTPPS: pixel dqm #18361

CTPPS: pixel dqm #18361

popovvp commented Apr 14, 2017

cmsbuild commented Apr 14, 2017 •

edited by smuzaffar

dmitrijus Apr 19, 2017

popovvp Apr 20, 2017

davidlange6 Apr 23, 2017

dmitrijus commented Apr 21, 2017

popovvp commented Apr 21, 2017 via email

cmsbuild commented Apr 21, 2017

dmitrijus commented Apr 21, 2017

cmsbuild commented Apr 21, 2017 •

edited

cmsbuild commented Apr 21, 2017

dmitrijus commented Apr 21, 2017

popovvp commented Apr 21, 2017 via email

cmsbuild commented Apr 21, 2017

cmsbuild commented Apr 21, 2017

cmsbuild commented Apr 21, 2017

cmsbuild commented May 3, 2017

dmitrijus commented May 3, 2017

cmsbuild commented May 3, 2017 •

edited

cmsbuild commented May 3, 2017

cmsbuild commented May 3, 2017

cmsbuild commented May 3, 2017

cmsbuild commented May 3, 2017

davidlange6 commented May 4, 2017

davidlange6 May 11, 2017

popovvp May 11, 2017

CTPPS: pixel dqm #18361

CTPPS: pixel dqm #18361

Conversation

popovvp commented Apr 14, 2017

cmsbuild commented Apr 14, 2017 • edited by smuzaffar

dmitrijus Apr 19, 2017

Choose a reason for hiding this comment

popovvp Apr 20, 2017

Choose a reason for hiding this comment

davidlange6 Apr 23, 2017

Choose a reason for hiding this comment

dmitrijus commented Apr 21, 2017

popovvp commented Apr 21, 2017 via email

cmsbuild commented Apr 21, 2017

dmitrijus commented Apr 21, 2017

cmsbuild commented Apr 21, 2017 • edited

cmsbuild commented Apr 21, 2017

dmitrijus commented Apr 21, 2017

popovvp commented Apr 21, 2017 via email

cmsbuild commented Apr 21, 2017

cmsbuild commented Apr 21, 2017

cmsbuild commented Apr 21, 2017

cmsbuild commented May 3, 2017

dmitrijus commented May 3, 2017

cmsbuild commented May 3, 2017 • edited

cmsbuild commented May 3, 2017

cmsbuild commented May 3, 2017

cmsbuild commented May 3, 2017

cmsbuild commented May 3, 2017

davidlange6 commented May 4, 2017

davidlange6 May 11, 2017

Choose a reason for hiding this comment

popovvp May 11, 2017

Choose a reason for hiding this comment

cmsbuild commented Apr 14, 2017 •

edited by smuzaffar

cmsbuild commented Apr 21, 2017 •

edited

cmsbuild commented May 3, 2017 •

edited