Fix thread-safety problems with beam spot fitting #18370

Dr15Jones · 2017-04-17T01:43:24Z

Changed how TH1::Fit was begin used to avoid thread-safety problems

forced ROOT to not use a global instance of Minuit
used the 'N' option of fitting to avoid adding the function to the
global list of functions (since that list is not properly protected
from manipulations from several threads simultaneously).

Changed how TH1::Fit was begin used to avoid thread-safety problems - forced ROOT to not use a global instance of Minuit - used the 'N' option of fitting to avoid adding the function to the global list of functions (since that list is not properly protected from manipulations from several threads simultaneously).

cmsbuild · 2017-04-17T01:43:45Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

RecoVertex/BeamSpotProducer

@perrotta, @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @slava77, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @tocheng, @VinInn, @rovere, @ebrondol, @dgulhan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

Dr15Jones · 2017-04-17T01:43:54Z

please test

cmsbuild · 2017-04-17T01:44:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19196/console Started: 2017/04/17 03:44

Dr15Jones · 2017-04-17T01:44:41Z

@davidlange6 this should fix all or at least most of the crashes in the recent 9_1_X.

cmsbuild · 2017-04-17T03:17:04Z

+1
Tested at: a26f8b9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18370/19196/summary.html

cmsbuild · 2017-04-17T03:17:07Z

Comparison job queued.

cmsbuild · 2017-04-17T05:34:12Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18370/19196/summary.html

Comparison Summary:

You potentially added 28 lines to the logs
Reco comparison results: 1643 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1819442
DQMHistoTests: Total failures: 38209
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 1781059
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

arunhep · 2017-04-17T13:54:33Z

not expected but folder containing SiStrip plots are broken in data wf 136.731 tests : https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_1_X_2017-04-16-2300+18370/19458/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/AlCaReco.html

Dr15Jones · 2017-04-17T13:57:12Z

please test

cmsbuild · 2017-04-17T13:57:26Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19199/console Started: 2017/04/17 15:59

cmsbuild · 2017-04-18T13:19:12Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19214/console Started: 2017/04/18 15:21

cmsbuild · 2017-04-18T15:21:29Z

+1
Tested at: a26f8b9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18370/19214/summary.html

cmsbuild · 2017-04-18T15:21:32Z

Comparison job queued.

Martin-Grunewald · 2017-04-18T16:21:19Z

FWIW, this PR solves the recent problems in the HLT Integration tests, which were of these types:

----- Begin Fatal Exception 18-Apr-2017 07:09:37 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing  stream end LuminosityBlock run: 1 luminosityBlock: 84
stream: 0
   [1] Calling method for module AlcaBeamMonitor/'AlcaBeamMonitor'
   Additional Info:
      [a] Fatal Root Error: @SUB=TF1::AddToGlobalList
Function is supposed to be in the global list but it is not present

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 18-Apr-2017 07:09:37 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing  stream end LuminosityBlock run: 1 luminosityBlock: 84
stream: 2
   [1] Calling method for module AlcaBeamMonitor/'AlcaBeamMonitor'
   Additional Info:
      [a] Fatal Root Error: @SUB=TF1::AddToGlobalList
Function is supposed to be in the global list but it is not present

----- End Fatal Exception -------------------------------------------------

davidlange6 · 2017-04-18T16:58:04Z

RecoVertex/BeamSpotProducer/BuildFile.xml

@@ -16,6 +16,7 @@
 <use   name="clhep"/>
 <use   name="rootcore"/>
 <use   name="rootminuit2"/>


is this obsolete now?

I had to add rootminuit dependency to get the symbol for TMinuitMinimizer. I didn't check to see if rootminuit2 can go away since I'm not certain why it was there to begin with.

I just tested and removing <use name="rootminuit2"/> does not appear to cause any adverse effects.
@davidlange6 do you want to me to update the pull request with this removed? Or do you want that as a seperate PR?

Separately is good. I'll merge this to restore the ibs...

cmsbuild · 2017-04-18T18:17:12Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18370/19214/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1744 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1819408
DQMHistoTests: Total failures: 35631
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1783604
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

davidlange6 · 2017-04-18T19:13:14Z

PLEase add any further comments for later review.

Dr15Jones · 2017-04-18T19:19:08Z

#18392 removed the unneeded dependency.

arunhep · 2017-04-18T19:28:37Z

+1

slava77 · 2017-04-18T20:04:07Z

+1

for #18370 a26f8b9

post-merge signoff. Looks OK.
it looks like earlier thread-related changes in the framework should have been tested in multi-thread environment first before breaking the IBs.

cmsbuild · 2017-04-18T20:04:21Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 17, 2017

cmsbuild added alca-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Apr 17, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 17, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 17, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 17, 2017

Dr15Jones mentioned this pull request Apr 17, 2017

Use multiple tasks for end stream transitions #18366

Merged

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved tests-pending labels Apr 17, 2017

cmsbuild added comparison-pending tests-pending and removed tests-rejected labels Apr 18, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 18, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 18, 2017

davidlange6 reviewed Apr 18, 2017

View reviewed changes

cmsbuild added comparison-available and removed comparison-pending labels Apr 18, 2017

davidlange6 merged commit 6ffec43 into cms-sw:master Apr 18, 2017

cmsbuild added alca-approved and removed alca-pending labels Apr 18, 2017

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Apr 18, 2017

Dr15Jones deleted the threadSafeBeamFitting branch May 4, 2017 16:06

dan131riley mentioned this pull request May 8, 2017

segfault in PVFitter::runFitter #18620

Closed

Dr15Jones mentioned this pull request Oct 2, 2021

More diagnostic plots for CSC trigger primitives in validation step #35329

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix thread-safety problems with beam spot fitting #18370

Fix thread-safety problems with beam spot fitting #18370

Dr15Jones commented Apr 17, 2017

cmsbuild commented Apr 17, 2017

Dr15Jones commented Apr 17, 2017

cmsbuild commented Apr 17, 2017 •

edited

Dr15Jones commented Apr 17, 2017

cmsbuild commented Apr 17, 2017

cmsbuild commented Apr 17, 2017

cmsbuild commented Apr 17, 2017

arunhep commented Apr 17, 2017

Dr15Jones commented Apr 17, 2017

cmsbuild commented Apr 17, 2017 •

edited

cmsbuild commented Apr 18, 2017 •

edited

cmsbuild commented Apr 18, 2017

cmsbuild commented Apr 18, 2017

Martin-Grunewald commented Apr 18, 2017

davidlange6 Apr 18, 2017

Dr15Jones Apr 18, 2017

Dr15Jones Apr 18, 2017

davidlange6 Apr 18, 2017

cmsbuild commented Apr 18, 2017

davidlange6 commented Apr 18, 2017

Dr15Jones commented Apr 18, 2017

arunhep commented Apr 18, 2017

slava77 commented Apr 18, 2017

cmsbuild commented Apr 18, 2017

Fix thread-safety problems with beam spot fitting #18370

Fix thread-safety problems with beam spot fitting #18370

Conversation

Dr15Jones commented Apr 17, 2017

cmsbuild commented Apr 17, 2017

Dr15Jones commented Apr 17, 2017

cmsbuild commented Apr 17, 2017 • edited

Dr15Jones commented Apr 17, 2017

cmsbuild commented Apr 17, 2017

cmsbuild commented Apr 17, 2017

cmsbuild commented Apr 17, 2017

arunhep commented Apr 17, 2017

Dr15Jones commented Apr 17, 2017

cmsbuild commented Apr 17, 2017 • edited

cmsbuild commented Apr 18, 2017 • edited

cmsbuild commented Apr 18, 2017

cmsbuild commented Apr 18, 2017

Martin-Grunewald commented Apr 18, 2017

davidlange6 Apr 18, 2017

Choose a reason for hiding this comment

Dr15Jones Apr 18, 2017

Choose a reason for hiding this comment

Dr15Jones Apr 18, 2017

Choose a reason for hiding this comment

davidlange6 Apr 18, 2017

Choose a reason for hiding this comment

cmsbuild commented Apr 18, 2017

davidlange6 commented Apr 18, 2017

Dr15Jones commented Apr 18, 2017

arunhep commented Apr 18, 2017

slava77 commented Apr 18, 2017

cmsbuild commented Apr 18, 2017

cmsbuild commented Apr 17, 2017 •

edited

cmsbuild commented Apr 17, 2017 •

edited

cmsbuild commented Apr 18, 2017 •

edited