Bringing 2017 HF simulation in sync with the data configuration #18372
Conversation
abdoulline
changed the title
|
A new Pull Request was created by @abdoulline (Salavat Abdullin) for master. It involves the following packages: SimCalorimetry/HcalSimProducers @civanch, @mdhildreth, @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
HF doesn't come out right, there is an issue to be sorted out... |
|
+1 |
cmsbuild
added
comparison-pending
and removed
comparison-available
simulation-approved
tests-approved
labels
|
Pull request #18372 was updated. @civanch, @mdhildreth, @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again. |
|
HF 2017 part of ZeroSuppression config has been updated to fix the issue induced by shrinking HF 2017 Digi size @civanch |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
@rekovic ping... |
|
hi @abdoulline - you have confirmed with the hcal validation team that the to-be-done issues in the validation code created by this PR will not be a problem for validation of the next prerelease? |
|
David, just 2-3 HF histos in Validation/HcalDigi are affected, the wast
majority of HF plots, especially high-level ones for RecHits and CaloTowers
are intact.
…On Thu, 20 Apr 2017, David Lange wrote:
hi @abdoulline - you have confirmed with the hcal validation team that the to-be-done issues in the validation code
created by this PR will not be a problem for validation of the next prerelease?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the
thread.[AEx02lSDmb7m2USqnXWLIp04QiTEMkwqks5rxwHJgaJpZM4M_V4D.gif]
|
|
so "yes"?
… On Apr 20, 2017, at 9:08 AM, Salavat Abdullin ***@***.***> wrote:
David, just 2-3 HF histos in Validation/HcalDigi are affected, the wast
majority of HF plots, especially high-level ones for RecHits and CaloTowers
are intact.
On Thu, 20 Apr 2017, David Lange wrote:
>
> hi @abdoulline - you have confirmed with the hcal validation team that the to-be-done issues in the validation code
> created by this PR will not be a problem for validation of the next prerelease?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the
> thread.[AEx02lSDmb7m2USqnXWLIp04QiTEMkwqks5rxwHJgaJpZM4M_V4D.gif]
>
>
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Yes (I'm a part of HCAL RelVal team anyway). |
|
merge
just avoiding any misunderstanding later
… On Apr 20, 2017, at 9:16 AM, Salavat Abdullin ***@***.***> wrote:
Yes (I'm a part of HCAL RelVal team anyway).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Already merged, but I also repeat "yes". We are working on updating the validation code, but it will be very helpful if you can merge the pending fully-signed PR. Thank you. #18159 18159 |
At P5 HCAL moved from 4TS to 3TS HF configuration and changed SOI ("sample of interest" = trigger one) from 3d to 2d TS.
This PR brings 2017 HF MC (DIGI and L1 emulation) in sync with the data.
NB: no changes expected for end-user, neither in HCAL Reco nor in L1 emulation,
while some code snippets in Validation/HcalDigis need to be modified to move from using ("absolute") hardcoded HF TS numbers to SOI-related ("relative") ones. To be done later.