ParticleLevelProducer based on Rivet

[mseidel42]

See #18402

[cmsbuild]

A new Pull Request was created by @intrepid42 (Markus Seidel) for master.

It involves the following packages:

GeneratorInterface/RivetInterface

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

[perrozzi]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19257/console Started: 2017/04/19 16:55

[cmsbuild]

Pull request #18404 was updated. @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please check and sign again.

[cmsbuild]

-1

Tested at: 37c80f8

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18404/19257/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

• Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-19-1100/src/GeneratorInterface/RivetInterface/plugins/RivetAnalyzer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-19-1100/src/GeneratorInterface/RivetInterface/plugins/GenParticles2HepMCConverter.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-19-1100/src/GeneratorInterface/RivetInterface/plugins/ParticleLevelProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-19-1100/src/GeneratorInterface/RivetInterface/plugins/DQMRivetClient.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-19-1100/src/GeneratorInterface/RivetInterface/plugins/ParticleLevelProducer.cc:1:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-19-1100/src/GeneratorInterface/RivetInterface/interface/ParticleLevelProducer.h:26:135: error: 'auto' not allowed in function prototype
  void addGenJet(Rivet::Jet jet, std::unique_ptr &jets, std::unique_ptr &consts, auto &constsRefHandle, int &iConstituent, std::unique_ptr &tags, auto &tagsRefHandle, int &iTag);
                                                                                                                                      ^~~~
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-19-1100/src/GeneratorInterface/RivetInterface/interface/ParticleLevelProducer.h:26:229: error: 'auto' not allowed in function prototype
  void addGenJet(Rivet::Jet jet, std::unique_ptr &jets, std::unique_ptr &consts, auto &constsRefHandle, int &iConstituent, std::unique_ptr &tags, auto &tagsRefHandle, int &iTag);
                                                                                                                                                                                                                                    ^~~~


[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18404/19257/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3263 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1826171
• DQMHistoTests: Total failures: 29653
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1796345
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[perrozzi]

@intrepid42 can you have a look at the conflict?

[cmsbuild]

Pull request #18404 was updated. @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please check and sign again.

[mseidel42]

Yes, that was an easy one ;)

The failed test should be fixed also, it was just that the fix came after the test was triggered.

[cmsbuild]

Pull request #18404 was updated. @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please check and sign again.

[perrozzi]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19321/console Started: 2017/04/21 15:53

[cmsbuild]

Pull request #18404 was updated. @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please check and sign again.

[mseidel42]

@davidlange6 Do you have any other comments after 70b8a68?

@perrozzi Could you trigger a new test, please?

[davidlange6]

please test
sorry missed the update

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19693/console Started: 2017/05/09 19:15

[cmsbuild]

+1
Tested at: 70b8a68
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18404/19693/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18404/19693/summary.html

Comparison Summary:

• You potentially added 846 lines to the logs
• Reco comparison results: 3366 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1834134
• DQMHistoTests: Total failures: 47760
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1786194
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[perrozzi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1