Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-coded RPC conditions #18459

Merged
merged 4 commits into from Apr 26, 2017
Merged

Remove hard-coded RPC conditions #18459

merged 4 commits into from Apr 26, 2017

Conversation

bapavlov
Copy link
Contributor

The conditions are now managed in the Global Tag, so we could remove the hard-coded conditions.

civanch and others added 4 commits February 22, 2017 16:50
Now the conditions are in the Global tag and the hard-coded one could be removed
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bapavlov for master.

It involves the following packages:

SimMuon/Configuration

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @trocino this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@bapavlov bapavlov mentioned this pull request Apr 25, 2017
@civanch
Copy link
Contributor

civanch commented Apr 25, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19376/console Started: 2017/04/25 14:37

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@civanch
Copy link
Contributor

civanch commented Apr 25, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18459/19376/summary.html

Comparison Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 69 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1780144
  • DQMHistoTests: Total failures: 14988
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1764983
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

hi @bapavlov -please make the title of this PR descriptive of the change. Thanks

@bapavlov bapavlov changed the title Patch 1 Remove_hardcoded_RPC_conditions Apr 26, 2017
@bapavlov bapavlov changed the title Remove_hardcoded_RPC_conditions Remove hardcoded RPC conditions Apr 26, 2017
@bapavlov bapavlov changed the title Remove hardcoded RPC conditions Remove hard-coded RPC conditions Apr 26, 2017
@bapavlov
Copy link
Contributor Author

hi @davidlange6 I have changed the title of the PR to "Remove hard-coded RPC conditions"

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d54dc8e into cms-sw:master Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants