RUn2-TB28 Add TB dependent module making algorithm to introduce rectangular absorber

[bsunanda]

The absorber layers are divided into 2 parts: one as part of the module, other rectangular shapes. They are applicable to 2017 TB

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19397/console Started: 2017/04/25 21:40

[cmsbuild]

+1
Tested at: 5411177
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18465/19397/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18465/19397/summary.html

Comparison Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 69 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1780110
• DQMHistoTests: Total failures: 179
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1779758
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[ianna]

+1

[kpedro88]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[cmsbuild]

Pull request #18465 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19509/console Started: 2017/05/02 14:32

[bsunanda]

@ianna @kpedro88 I just changed variable names as suggested by David. Could you approve this PR?

[cmsbuild]

+1
Tested at: c4498dc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18465/19509/summary.html

[cmsbuild]

Comparison job queued.

[kpedro88]

+1

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18465/19509/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3360 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1831595
• DQMHistoTests: Total failures: 33467
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1797948
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[davidlange6]

+1