Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate PixelTrackFilter classes to getByToken #1847

Merged
merged 2 commits into from Dec 17, 2013

Conversation

makortel
Copy link
Contributor

Migrate HIProtoTrackFilter and HIPixelTrackFilter to getByToken(). As a consequence, PixelTrackFilter objects are constructed from EDModule constructos in order to deliver edm::ConsumesCollector. In addition, edm::EventSetup is always delivered in PixelTrackFilter::update, and it is up to the deriving class to use it or not (previously edm::EventSetup was delivered in the PixelTrackFilter constructor if needed).

Configuration parameter useFilterWithES in PixelTrackReconstruction class became obsolete, I added LogInfo message for that.

Needed because HIPixelTrackFilter and HIProtoTrackFilter (both derive
from PixelTrackFilter) read from edm::Event.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_0_X.

Migrate PixelTrackFilter classes to getByToken

It involves the following packages:

FastSimulation/Tracking
RecoHI/HiTracking
RecoMuon/TrackerSeedGenerator
RecoPixelVertexing/PixelLowPtUtilities
RecoPixelVertexing/PixelTrackFitting

@nclopezo, @lveldere, @cmsbuild, @anton-a, @thspeer, @giamman, @slava77 can you please review it and eventually sign? Thanks.
@azsigmon, @yslai, @cbaus, @GiacomoSguazzoni, @jazzitup, @yenjie, @rovere, @kurtejung, @cerati, @mandrenguyen, @richard-cms, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@lveldere
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@thspeer
Copy link
Contributor

thspeer commented Dec 17, 2013

+1
tested 2959b71 in CMSSW_7_0_X_2013-12-17-0200_PixelTrackFilter
No difference in reco as expected, based on RelMon and reco script

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

ktf added a commit that referenced this pull request Dec 17, 2013
…Filter

Consumes migration -- Migrate PixelTrackFilter classes to getByToken
@ktf ktf merged commit 0b87c48 into cms-sw:CMSSW_7_0_X Dec 17, 2013
@makortel makortel deleted the tracking_getbytoken_PixelTrackFilter branch October 20, 2016 10:16
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Update root to the tip of 6.02 branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants