New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate PixelTrackFilter classes to getByToken #1847
Migrate PixelTrackFilter classes to getByToken #1847
Conversation
Needed because HIPixelTrackFilter and HIProtoTrackFilter (both derive from PixelTrackFilter) read from edm::Event.
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_0_X. Migrate PixelTrackFilter classes to getByToken It involves the following packages: FastSimulation/Tracking @nclopezo, @lveldere, @cmsbuild, @anton-a, @thspeer, @giamman, @slava77 can you please review it and eventually sign? Thanks. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
…Filter Consumes migration -- Migrate PixelTrackFilter classes to getByToken
Update root to the tip of 6.02 branch.
Migrate HIProtoTrackFilter and HIPixelTrackFilter to
getByToken()
. As a consequence,PixelTrackFilter
objects are constructed from EDModule constructos in order to deliveredm::ConsumesCollector
. In addition,edm::EventSetup
is always delivered inPixelTrackFilter::update
, and it is up to the deriving class to use it or not (previouslyedm::EventSetup
was delivered in thePixelTrackFilter
constructor if needed).Configuration parameter
useFilterWithES
inPixelTrackReconstruction
class became obsolete, I added LogInfo message for that.