Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added L1 Muon EtaAtVtx and PhiAtVtx histograms for Online DQM #18478

Merged
merged 1 commit into from May 3, 2017

Conversation

stahlleiton
Copy link
Contributor

Include Online DQM histograms for the new L1 muon variables: EtaAtVtx and PhiAtVtx

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2017

A new Pull Request was created by @stahlleiton (Andre Stahl) for master.

It involves the following packages:

DQM/L1TMonitor

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@kreczko this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@stahlleiton
Copy link
Contributor Author

Could someone please start the test.

@dmitrijus
Copy link
Contributor

The PR looks fine, but can you tell us who you are?
(and someone from L1T should confirm)

@stahlleiton
Copy link
Contributor Author

I am currently helping on L1T Muon DQM related tasks and @thomreis can confirm that.

@thomreis
Copy link
Contributor

thomreis commented May 2, 2017

Hi,
I do confirm. Andre is working on the L1 muon online DQM.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19527/console Started: 2017/05/02 18:32

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18478/19527/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831629
  • DQMHistoTests: Total failures: 31570
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1799879
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6f70fa4 into cms-sw:master May 3, 2017
@stahlleiton stahlleiton deleted the OnlineDQML1TMuon_EtaPhiAtVtx branch February 20, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants