New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around: allow production of LHERunInfoProduct at begin Run #18499
Work around: allow production of LHERunInfoProduct at begin Run #18499
Conversation
Other modules in the schedule require that LHERunInfoProduct be available in the Run at begin run time even though the data product is mergeable. ExternalLHEProducer also puts the product in at both begin and end run time which is not a behavior expected by the framework and just happens to work.
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: GeneratorInterface/LHEInterface @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
This fixes the failures in the IB, such as [I do not know why my original tests which ran the entire runTheMatrix.py missed these] |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
Hi Chris, Should this allow also to read the LHERunInfoProduct at any beginRun method in subsequent processes on the file? I tried today on This is a big problem since AFAIK this is the product from which one can read the meaning of the LHE weights, and so it's needed before processing the events, not after. |
The object gets modified each time a new file is openned which contains the same run. Therefore the weights keep changing until the end Run transition happens. |
That may be true of the cross section information stored in the LHE init block, but it's not true of the header information strings that people mostly need to access. |
Uh, won't this pull request as is completely break the storage of cross section information in the LHE run product? |
could the more stable header information be put in a product that is readable at begin run? |
Other modules in the schedule require that LHERunInfoProduct be
available in the Run at begin run time even though the data product
is mergeable.
ExternalLHEProducer also puts the product in at both begin and end
run time which is not a behavior expected by the framework and
just happens to work.