Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #18353 to 90X, plus update TP nsamples and adc2fC #18509

Closed

Conversation

DryRun
Copy link
Contributor

@DryRun DryRun commented Apr 28, 2017

Backports #18353 to 9_0_2 for online DQM.

For correcting the number of samples in HF TP emulation, I merged the following:

I also changed the adc2fC conversion to use the DB values as in normal reconstruction, rather than a hard-coded lookup table.

These additional two items will be incorporated into the next PR to 9_1_X (coordinate with the TP nsamples PRs).

@christopheralanwest

matz-e and others added 30 commits April 3, 2017 09:10
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 28, 2017

A new Pull Request was created by @DryRun (David Yu) for CMSSW_9_0_X.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks
DQM/Integration
DQMOffline/Configuration
SimCalorimetry/HcalTrigPrimAlgos

@dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @batinkov, @deguio, @rociovilar this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

No longer a backport, cannot be merged.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

Pull request #18509 was updated. @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

@davidlange6
Copy link
Contributor

Closing PR. CMSSW_9_0_X development has completed (CMSSW_9_2_X is for data taking)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants