Fixing race condition in EvFDaqDirector #18516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using preSourceEvent. Moving this vector to "read" in the input source and reading stream ID from eventPrincipal, which makes this mechanism thread safe*. * under assumption that "getNextEvent" and "read" are mutually exclusive and without data races between them, and run in sequence (one getNextEvent followed by one read). (more than just currentFileIndex_ updates rely on this behavior)
*small fix for singleBufferMode (non-default mode): fix premature exit of the thread in case empty file is seen *removed obsolete comments
|
A new Pull Request was created by @smorovic (Srecko Morovic) for master. It involves the following packages: EventFilter/Utilities @perrotta, @emeschi, @cmsbuild, @slava77, @mommsen, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DaqDirector was used to keep track of which file (based on which event) is being processed by which file.
This was not done in thread safe manner, as described in issue #18356
This patch retrives event (file) stream ID from "read" in the input source instead of relying on preSourceEvent in DaqDirector, which can be executed in a different thread.