Adding new instances of HLTCaloObjInRegionsProducer for HLT filtering

[Sam-Harper]

This PR adds new templated instances of HLTCaloObjInRegionsProducer to allow it to filter on new types.

This module is used in the HLT to prefilter calo objects (digis currently) to only run computational expensive things on the objects needed. The main use case is running HCAL method 2 for just HCAL hits which interest e/gamma.

The main motivation is to allow it to filter on QE11 HCAL digis for HEP17. At this time I also added in the ability for it to filter ECAL + ES digis incase the time to run multifit globally is to much. Finally I added EcalRecHit and EcalUncalibratedRecHit instances so it could can eventually replace HLTRecHitInAllL1RegionsProducer instances which is a very similar but not as flexable module which is now redundant.

Some minor changes were needed to make the HLTCaloObjInRegionsProducer function with the new objects (front -> begin , wrapping id() in to a DetId as some return ints, some return DetIds).

Finally I also added a function to EB and EE DigiCollections to allow a Digi to be directly pushed back to them like all other Digi collections I've encountered in CMS.

[cmsbuild]

A new Pull Request was created by @Sam-Harper for master.

It involves the following packages:

DataFormats/EcalDigi
RecoEgamma/EgammaHLTProducers

@cmsbuild, @civanch, @silviodonato, @mdhildreth, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @rafaellopesdesa, @lgray, @calderona, @HuguesBrun, @argiro this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

[Sam-Harper]

Oh and I forgot the mention, the testUCTUnpacker in EventFilter/L1TXRawToDigi fails. I think this is because its being called incorrectly, the testUCTUnpacker is expecting input on cin its not getting, ie it should be called like:
$CMSSW_BASE/tmp/$SCRAM_ARCH/src/EventFilter/L1TXRawToDigi/test/testUCTUnpacker/testUCTUnpacker < event_test1.txt

when called like this it does work

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19528/console Started: 2017/05/02 18:35

[cmsbuild]

+1
Tested at: d1bfa1a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18544/19528/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18544/19528/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 1555 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1831629
• DQMHistoTests: Total failures: 21924
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1809525
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[fwyzard]

looks OK from a quick glance...

[civanch]

+1

[Martin-Grunewald]

This PR has now become a 92X PR - please make a 91X PR as well.

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1