Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated (in C++11) 'register' keyword #18566

Merged
merged 1 commit into from May 5, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented May 4, 2017

'register' keyword was deprecated in 2009 (or in C++11) standard and
finally removed in C++17.

Quote:

The register keyword serves very little function, offering no more
than a hint that a note says is typically ignored. It should be
deprecated in this version of the standard, freeing the reserved name up
for use in a future standard, much like auto has been re-used this time
around for being similarly useless.

See: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4193.html#809

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

'register' keyword was deprecated in 2009 (or in C++11) standard and
finally removed in C++17.

Quote:

    The register keyword serves very little function, offering no more
    than a hint that a note says is typically ignored. It should be
    deprecated in this version of the standard, freeing the reserved name up
    for use in a future standard, much like auto has been re-used this time
    around for being similarly useless.

See: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4193.html#809

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

A new Pull Request was created by @davidlt for master.

It involves the following packages:

CondFormats/Common
DetectorDescription/Core
PhysicsTools/MVATrainer
SimRomanPot/SimFP420

@ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @mdhildreth, @monttj, @cmsbuild, @franzoni, @cerminar, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @imarches, @acaudron, @tocheng, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@davidlt
Copy link
Contributor Author

davidlt commented May 4, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19567/console Started: 2017/05/04 13:46

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18566/19567/summary.html

Comparison Summary:

  • You potentially added 398 lines to the logs
  • Reco comparison results: 1712 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1829090
  • DQMHistoTests: Total failures: 40203
  • DQMHistoTests: Total nulls: 22
  • DQMHistoTests: Total successes: 1788685
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@ianna
Copy link
Contributor

ianna commented May 4, 2017

+1

1 similar comment
@civanch
Copy link
Contributor

civanch commented May 4, 2017

+1

@arunhep
Copy link
Contributor

arunhep commented May 5, 2017

+1

@davidlange6 davidlange6 merged commit 6438664 into cms-sw:master May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants