Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECAL aging condition customizations [91X] #18593

Merged
merged 1 commit into from May 12, 2017

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented May 5, 2017

Backport of #18592

@kpedro88
Copy link
Contributor Author

kpedro88 commented May 5, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19614/console Started: 2017/05/05 23:07

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_1_X.

It involves the following packages:

SLHCUpgradeSimulations/Configuration

@cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ebrondol, @sviret this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

-1

Tested at: d9442c3

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18593/19614/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@kpedro88
Copy link
Contributor Author

kpedro88 commented May 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19616/console Started: 2017/05/06 08:31

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18593/19616/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3374 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831084
  • DQMHistoTests: Total failures: 47577
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1783327
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@civanch
Copy link
Contributor

civanch commented May 6, 2017

+1

@kpedro88
Copy link
Contributor Author

kpedro88 commented May 7, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9abb3d2 into cms-sw:CMSSW_9_1_X May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants