New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding back few Module level maps #18627
Conversation
A new Pull Request was created by @fioriNTU for master. It involves the following packages: DQM/SiPixelPhase1Clusters @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
hi @fioriNTU @dmitrijus - how many more histogram bins does this imply? |
There are 30 more histograms, the total bins are 1856 (# of pixel modules) * 5 = 9280 |
+1
*30 I guess. or 600kB. Seems ok
… On May 10, 2017, at 9:28 AM, fioriNTU ***@***.***> wrote:
There are 30 more histograms, the total bins are 1856 (# of pixel modules) * 5 = 9280
If this is too much I can disable other less important histograms, but the ones I am adding here would be extremely useful to have in production.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@davidlange6 the number of bins is correct, you have not to multiply by 30, 1856 is the total number of bins in a set of 6 plots. So, it should be more than ok :-) |
Adding back few module level plots for cluster cherge, size, and digi ADC