Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding back few Module level maps #18627

Merged
merged 1 commit into from May 10, 2017
Merged

adding back few Module level maps #18627

merged 1 commit into from May 10, 2017

Conversation

fioriNTU
Copy link
Contributor

@fioriNTU fioriNTU commented May 9, 2017

Adding back few module level plots for cluster cherge, size, and digi ADC

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

A new Pull Request was created by @fioriNTU for master.

It involves the following packages:

DQM/SiPixelPhase1Clusters
DQM/SiPixelPhase1Digis
DQM/SiPixelPhase1TrackClusters

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @hdelanno this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19686/console Started: 2017/05/09 18:07

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18627/19686/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3297 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831050
  • DQMHistoTests: Total failures: 47004
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 1783865
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

hi @fioriNTU @dmitrijus - how many more histogram bins does this imply?

@fioriNTU
Copy link
Contributor Author

There are 30 more histograms, the total bins are 1856 (# of pixel modules) * 5 = 9280
If this is too much I can disable other less important histograms, but the ones I am adding here would be extremely useful to have in production.

@davidlange6
Copy link
Contributor

davidlange6 commented May 10, 2017 via email

@cmsbuild cmsbuild merged commit 7ec0bb6 into cms-sw:master May 10, 2017
@fioriNTU
Copy link
Contributor Author

@davidlange6 the number of bins is correct, you have not to multiply by 30, 1856 is the total number of bins in a set of 6 plots. So, it should be more than ok :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants