Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase2-hgx79 Defining wafer using Extruded Polygon #18659

Merged
merged 4 commits into from May 16, 2017
Merged

Phase2-hgx79 Defining wafer using Extruded Polygon #18659

merged 4 commits into from May 16, 2017

Conversation

bsunanda
Copy link
Contributor

Also adding a simpler algorithm

@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone May 10, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 10, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19717/console Started: 2017/05/10 14:55

@cmsbuild
Copy link
Contributor

-1

Tested at: 809a837

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18659/19717/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_MC.root : FAILED - time: date Wed May 10 15:57:00 2017-date Wed May 10 15:52:01 2017 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-05-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed May 10 15:57:00 2017-date Wed May 10 15:52:01 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Wed May 10 15:57:00 2017-date Wed May 10 15:52:01 2017 s - exit: 21504

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ianna
Copy link
Contributor

ianna commented May 10, 2017

+1

test failures are unrelated to this PR

@ianna
Copy link
Contributor

ianna commented May 10, 2017

+1

kpedro88
kpedro88 reviewed May 10, 2017
View reviewed changes
Geometry/HGCalCommonData/plugins/DDHGCalWafer.cc Outdated
<< childNames_[1] << " in namespace " << idNameSpace_
<< " positioned in " << nCellsRow_.size() << " rows and "
<< nColumns_ << " columns with lowest column at " << nBottomY_
<< " in moher " << parentName_ << " of size " << waferSize_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo moher -> mother

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18659/19717/summary.html

Comparison Summary:

  • You potentially added 24138 lines to the logs
  • Reco comparison results: 3371 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1830338
  • DQMHistoTests: Total failures: 33614
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1796544
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 11, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19752/console Started: 2017/05/11 10:36

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19835/console Started: 2017/05/15 20:45

@cmsbuild
Copy link
Contributor

Pull request #18659 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please check and sign again.

@ianna
Copy link
Contributor

ianna commented May 15, 2017

+1

@kpedro88
Copy link
Contributor

+1

1 similar comment
@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: e8f81a0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18659/19835/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18659/19835/summary.html

Comparison Summary:

  • You potentially added 30 lines to the logs
  • Reco comparison results: 1673 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1829428
  • DQMHistoTests: Total failures: 23315
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1805933
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9cb53ac into cms-sw:master May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpedro88 kpedro88 kpedro88 left review comments

Assignees
No one assigned
Labels
comparison-available fully-signed geometry-approved orp-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bsunanda @cmsbuild @ianna @kpedro88 @davidlange6