Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consumes validation reco vertex #1866

Merged
merged 20 commits into from Dec 18, 2013

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Dec 18, 2013

Consumes fix for the following modules in package Validation/RecoVertex:
Validation/RecoVertex/src/AnotherPrimaryVertexAnalyzer.cc
Validation/RecoVertex/src/BSvsPVAnalyzer.cc
Validation/RecoVertex/src/BeamSpotAnalyzer.cc
Validation/RecoVertex/src/MCVerticesAnalyzer.cc
Validation/RecoVertex/src/MCVerticesWeight.cc
Validation/RecoVertex/src/MCvsRecoVerticesAnalyzer.cc
Validation/RecoVertex/src/PrimaryVertexAnalyzer.cc
Validation/RecoVertex/src/PrimaryVertexAnalyzer4PU.cc
Validation/RecoVertex/src/TrackParameterAnalyzer.cc
Validation/RecoVertex/src/V0Validator.cc
Validation/RecoVertex/src/VertexHistogramMaker.cc
Tested with workflow 3 of whiteRabbit.
As a general comment, some of those modules should be rewritten from scratch. I tried to optimise a bit PrimaryVertexAnalyzer, but in the case of PrimaryVertexAnalyzer4PU what I did was just removing getByLabel and unneeded includes. Please inform developers about them.

Salvatore Di Guida added 20 commits December 2, 2013 12:42
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
…alyzer AnotherPrimaryVertexAnalyzer which uses it as helper.

Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @diguida for CMSSW_7_0_X.

Fix consumes validation reco vertex

It involves the following packages:

Validation/RecoVertex

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@deguio
Copy link
Contributor

deguio commented Dec 18, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 18, 2013
Consumes migration -- Fix consumes validation reco vertex
@ktf ktf merged commit e0c37a9 into cms-sw:CMSSW_7_0_X Dec 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants