Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T O2O Utilities for fetching information from Online and Offline DBs #18665

Merged
merged 10 commits into from May 12, 2017

Conversation

kkotov
Copy link
Contributor

@kkotov kkotov commented May 10, 2017

A set of script for accessing DBs along with the documentation was updated.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kkotov (Khristian Kotov) for master.

It involves the following packages:

L1TriggerConfig/Utilities

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #18665 was updated. @ggovi, @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

@kkotov kkotov mentioned this pull request May 10, 2017
@rekovic
Copy link
Contributor

rekovic commented May 10, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19728/console Started: 2017/05/10 17:56

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18665/19728/summary.html

Comparison Summary:

  • You potentially added 198 lines to the logs
  • Reco comparison results: 3360 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1830372
  • DQMHistoTests: Total failures: 33349
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1796843
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@kkotov
Copy link
Contributor Author

kkotov commented May 11, 2017

@rekovic , this PR leaves most of the c++ code intact (except removing some unused class and changing L1TCaloStage2ParamsRcd to L1TCaloParamsRcd for consistency with other pending PRs in my Utilities package). Most of this PR is a bunch of scripts and a readme instruction how to use those, so it must pose no problems to review and sign off.

@rekovic
Copy link
Contributor

rekovic commented May 11, 2017

+1

@davidlange6 davidlange6 merged commit 7e2a924 into cms-sw:master May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants