supercluster eta -> seed eta for e/g pixel matching: 91X

[Sam-Harper]

91X flavour of: #18679

This PR changes the eta used for the calo position from the supercluster eta to the seed eta. This is because the supercluster eta is slightly biased w.r.t to the original particles position and so distorts the matching when the electron brems.

This improves our pixel matching performance and is sadly necessary for the HLT. The good news is that it only effects a module used by the HLT so can not effect RECO.

For more information please see Junho Kim's presentation in E/gamma last friday (05/05/17):
https://indico.cern.ch/event/613829/contributions/2581351/attachments/1454808/2244939/5.5.2017_HLTEGv4.pdf

I think with this, the E/gamma HLT pixel matching finally has a good baseline and is sufficient for initial running. Thank you for your patience on this!

[cmsbuild]

A new Pull Request was created by @Sam-Harper for CMSSW_9_1_X.

It involves the following packages:

RecoEgamma/EgammaElectronProducers

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@rafaellopesdesa, @lgray this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[slava77]

backport of #18679

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19737/console Started: 2017/05/10 22:20

[cmsbuild]

+1
Tested at: 4a4330b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18680/19737/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18680/19737/summary.html

Comparison Summary:

• You potentially added 3885 lines to the logs
• Reco comparison results: 3363 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1831084
• DQMHistoTests: Total failures: 32994
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1797910
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[perrotta]

+1
backport of #18679 , already signed in the master
Modification of a module that will be used in future HLT development.
The justification of the update is in the plots in the initial description of this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1