Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make L1MuDTTFConfig thread safe #18682

Merged

Conversation

Dr15Jones
Copy link
Contributor

Minimized the number of statics which could be obtained from L1MuDTTFConfig
and made the remaining ones atomic.
This allows the last thread_unsafe::DQMEDAnalyzer, L1TdeCSCTF,
to be converted to a DQMEDAnalyzer.

Minimized the number of statics which could be obtained from L1MuDTTFConfig
and made the remaining ones atomic.
This allows the last thread_unsafe::DQMEDAnalyzer, L1TdeCSCTF,
to be converted to a DQMEDAnalyzer.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DQM/L1TMonitor
L1Trigger/CSCTrackFinder
L1Trigger/DTTrackFinder

@dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19739/console Started: 2017/05/10 22:46

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18682/19739/summary.html

Comparison Summary:

  • You potentially added 34 lines to the logs
  • Reco comparison results: 1679 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1829175
  • DQMHistoTests: Total failures: 8561
  • DQMHistoTests: Total nulls: 204
  • DQMHistoTests: Total successes: 1820230
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@dmitrijus
Copy link
Contributor

+1

@rekovic
Copy link
Contributor

rekovic commented May 16, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e0880d8 into cms-sw:master May 17, 2017
@Dr15Jones Dr15Jones deleted the removeLastThreadUnsafeDQMEDAnalyzer branch May 18, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants