Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from boost::regex to std::regex #18727

Merged

Conversation

Dr15Jones
Copy link
Contributor

The helgrind tool reported that boost::regex was sharing memory
between threads. To be sure we are thread safe, switched code to
use std;:regex. This has the added benefit of using more of the
standard library which is more future proof than boost.

The helgrind tool reported that boost::regex was sharing memory
between threads. To be sure we are thread safe, switched code to
use std;:regex. This has the added benefit of using more of the
standard library which is more future proof than boost.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19807/console Started: 2017/05/13 16:26

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18727/19807/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 95 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1830696
  • DQMHistoTests: Total failures: 46536
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1783980
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6188af6 into cms-sw:master May 15, 2017
@Dr15Jones Dr15Jones deleted the changeToStdRegexHLTTauDQMOfflineSource branch May 18, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants