Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing #include <iostream> in BasicPayload.h #18761

Merged
merged 1 commit into from May 17, 2017

Conversation

Teemperor
Copy link
Contributor

@Teemperor Teemperor commented May 16, 2017

We use std::cout in this header, so we also need to include iostream.

We use std::cout in this header, so we also need to include <iostream>.
@Teemperor
Copy link
Contributor Author

Part of #15248

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

CondFormats/Common

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@franzoni
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19872/console Started: 2017/05/16 20:17

@franzoni
Copy link

+1

@ggovi
Copy link
Contributor

ggovi commented May 16, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18761/19872/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1716 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833892
  • DQMHistoTests: Total failures: 24369
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1809343
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 17f19ec into cms-sw:master May 17, 2017
@Teemperor Teemperor deleted the MissingIncludeBasicPayload.h branch December 19, 2017 08:47
@Teemperor Teemperor restored the MissingIncludeBasicPayload.h branch December 19, 2017 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants