Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fireworks 92X: Visualization of HGCal rec hits in Lego view. #18777

Merged
merged 1 commit into from May 17, 2017

Conversation

alja
Copy link
Contributor

@alja alja commented May 16, 2017

Add Visualiation of HGCal rec hits.
Note cells are not in regular eta,phi bins. and the view. TEveCaloData is added in HF Lego view.
zoom
all

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for master.

It involves the following packages:

Fireworks/Calo
Fireworks/Core

@cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@alja
Copy link
Contributor Author

alja commented May 16, 2017

How to run

The HF Lego view is visible onlu in expert mode
./cmsShow --expert data.root

@alja
Copy link
Contributor Author

alja commented May 16, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19899/console Started: 2017/05/17 07:38

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fa947b6 into cms-sw:master May 17, 2017
@alja alja deleted the hgcal branch April 8, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants