Backport: RPCRecHits nan protection

[jhgoh]

Backport of #18955

[cmsbuild]

A new Pull Request was created by @jhgoh (Junghwan John Goh) for CMSSW_9_1_X.

It involves the following packages:

RecoLocalMuon/RPCRecHit

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@bellan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

@jhgoh
I doubt that there will be a bugfix release in 91X.
@kpedro88 is there something planned?

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20128/console Started: 2017/05/26 06:03

[jhgoh]

@slava77 that's the biggest problem of this PR.
Actually I realized this bug while preparing a report of 911 release validation.

[kpedro88]

@slava77 still TBD, probably depends on how many studies a bug will impact (and how many bugs are found)

[cmsbuild]

+1
Tested at: f9fecde
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18956/20128/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18956/20128/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 1675 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1834225
• DQMHistoTests: Total failures: 52736
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1781309
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[jhgoh]

including @calabria @jshlee to inform that we have a bugfix PR.

[cmsbuild]

Pull request #18956 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20152/console Started: 2017/05/27 21:19

[cmsbuild]

+1
Tested at: 4dc0794
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18956/20152/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18956/20152/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3358 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1834225
• DQMHistoTests: Total failures: 48354
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1785691
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[perrotta]

+1
This is a backport of #18955 : bug fix, same comments as for the PR submitted in the master

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1