Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made static in L1ExtraParticlesProd const #1900

Merged

Conversation

Dr15Jones
Copy link
Contributor

The static analyzer complained about a non-const static being used. The static was set at initialization time and then never changed so it was trivial to make const.

The static analyzer complained about a non-const static being used. The static was set at initialization time and then never changed so it was trivial to make const.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Made static in L1ExtraParticlesProd const

It involves the following packages:

L1Trigger/L1ExtraFromDigis

@cmsbuild, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

ktf added a commit that referenced this pull request Dec 19, 2013
…clesProd

Multithreading fixes -- Made static in L1ExtraParticlesProd const
@ktf ktf merged commit ce8a4ae into cms-sw:CMSSW_7_0_X Dec 19, 2013
@ktf
Copy link
Contributor

ktf commented Dec 19, 2013

Trivial, bypassing signature.

@Dr15Jones Dr15Jones deleted the makeStaticConstInL1ExtraParticlesProd branch January 3, 2014 17:03
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Upgrade Frontier client to version 2.8.14 and pacparser to 1.3.5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants