PR #18236 backport to 91X #19026
PR #18236 backport to 91X #19026
Conversation
…rd-coded but tested and working
…ding boolean option
…ches changes in producer)
…zside use in HGCalImagingAlgo which was not aware of BH HCalDetId
… spaces, update multiclustering as discussed with conveners
|
A new Pull Request was created by @clelange (Clemens Lange) for CMSSW_9_1_X. It involves the following packages: RecoLocalCalo/HGCalRecAlgos @perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@clelange the HGCal TDR production won't be done with 91X... |
|
Hmm, OK, I was told that this needed to be backported to 91X... I'll talk to @cseez et al. tomorrow anyway. |
|
Back when we thought the original PR would converge before the muon/barrel TDR release was cut, we discussed backporting it to 91X. But now the TDR release is out, and it's not clear to me that this is a viable addition for a future bug-fix release. |
|
@kpedro88 Can we at least please test this already to avoid further delays while we're discussing with the upgrade conveners? |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
These are the collected HGCal reconstruction (clustering) as in #18236 plus the two missing
numericincludes to fix potential gcc6/7 compilation errors aboutstd::iota. I backported them to CMSSW_9_1_X, performedgit cms-checkdeps -aand compiled the full code successfully. These changes are required in 91X for the HGCal TDR.