Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning Phase1 Clients #19134

Merged
merged 1 commit into from Jun 10, 2017
Merged

Cleaning Phase1 Clients #19134

merged 1 commit into from Jun 10, 2017

Conversation

fioriNTU
Copy link
Contributor

@fioriNTU fioriNTU commented Jun 7, 2017

This PR:

  1. add the Era mechanism to Pixel Phase1 clients

  2. uniformate HLT selection in the two clients

  3. clean what was left of the Phase 0 code

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

A new Pull Request was created by @fioriNTU for master.

It involves the following packages:

DQM/Integration

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@fioriNTU fioriNTU mentioned this pull request Jun 7, 2017
@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20453/console Started: 2017/06/09 15:01

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19134/20453/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1872323
  • DQMHistoTests: Total failures: 20202
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1851948
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 13c94e9 into cms-sw:master Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants