Fix precise setting for CaloSamplesAnalyzer with HPDs

[kpedro88]

In #16907, I added a tool called CaloSamplesAnalyzer to help debug intermediate stages of the HCAL digitization simulation. This included a special "precise" option for the HPD simulation, to get per-nanosecond CaloSamples (instead of just per-timeslice=per-25ns).

However, it was recently pointed out to me that activating this debugging option caused the output digis to change. This is because the HPD pulse shape is integrated over 25ns by the CaloCachedShapeIntegrator before it is used by the simulation - so the "precise" setting was effectively integrating the pulse twice. To resolve this, I made a separate map of un-integrated pulses to be used in "precise" mode. I also cleaned up the HcalShapes code, to make it more maintainable and modern.

This PR should not change any standard results. The observed problem was only seen in a special debugging mode.

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20480/console Started: 2017/06/09 23:05

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

SimCalorimetry/CaloSimAlgos
SimCalorimetry/HcalSimAlgos

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@mariadalfonso this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 7e00899
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19184/20480/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19184/20480/summary.html

Comparison Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1872289
• DQMHistoTests: Total failures: 20110
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1852006
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1