CTPPS: fixes for 2017 diamond data taking operations

[forthommel]

This PR introduces a set of useful fixes for 2017 data-taking with CTPPS diamond detector, namely:

• a bug fix in the rechits time-over-threshold computation (removed the extra time-slice subtraction)
• lighter DQM source (reduced number of output histograms, coarser binnings)

[cmsbuild]

A new Pull Request was created by @forthommel (Laurent Forthomme) for master.

It involves the following packages:

DQM/CTPPS
RecoCTPPS/TotemRPLocal

@perrotta, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20481/console Started: 2017/06/09 23:26

[cmsbuild]

+1
Tested at: 2f8ae18
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19185/20481/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19185/20481/summary.html

Comparison Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1870707
• DQMHistoTests: Total failures: 49458
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1821076
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[forthommel]

Imho: for the rechits producer, as the correction only involves the timing part (new in 2017 with the use of the reference clock), no requirement to backport it.

[dmitrijus]

+1

[cmsbuild]

Pull request #19185 was updated. @perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20917/console Started: 2017/06/26 17:27

[cmsbuild]

+1
Tested at: 205ae9f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19185/20917/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
fc51b5b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19185/20917/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19185/20917/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19185/20917/summary.html

Comparison Summary:

• You potentially added 11 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1812148
• DQMHistoTests: Total failures: 29344
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1782638
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[forthommel]

Perfect! @davidlange6?

[slava77]

+1

for #19185 205ae9f

• changes made since the last reco signoff do not affect reco (only in DQM/CTPPS/plugins/CTPPSDiamondDQMSource.cc)
• jenkins tests pass (standard jenkins tests do not include data with diamonds)

@forthommel
this PR was advanced to 93X. You will need to make a backport to 92X, if it is needed in data taking soon.

[forthommel]

@slava77 Perfect! Of course...!

[davidlange6]

merge

[forthommel]

Thanks, @davidlange6 !