New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run2-gem28 Add a new version of GE11 geometry slice #19190
Conversation
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/CMSCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
hi- @bsunanda - is there a summary of the motivations behind the changes in indico? |
@davidlange6 I am not sure. Cesare and Teruki contacted me and it was verified by hardware people. These positions refer to the real positions of chambers installed on CMS last YETS |
please follow up with them - geometry changes should not come undocumented at this point |
@davidlange6 simply the previous geometry was wrong, it did not reflect the chambers we actually installed. In the previous geometry we had E-1 CH19,26,27,28,29 but actually the installed chambers are E-1 CH1,27,28,29,30. Please, have a look here: https://indico.cern.ch/event/641682/contributions/2603235/attachments/1474368/2282957/DPG-GEMMiniWorkShopJune2017.pdf , slides 9, 10 and 11. The current situation is the one that you see in the pic ture in attachment. |
@davidlange6 Chambers 1, 27, 28, 29, 30 installed on z =-1 side. The new geometry reflects that. I don't understand your comment. |
all is clear already - please edit the description at the top of the PR (eg, the first comment) to reflect what this PR really does rather than a vague comment that implies small changes |
+1 |
This new version reflects the real situation of installed GE1 chambers (in locations 1,27,28,29,30 on -z side). The earlier description was wrong