[92X] Add Payload Inspector classes for SiStripApvGains #19193

mmusich · 2017-06-12T12:16:48Z

Greetings,
this PR adds several types of plots for quick and basic SiStripApvGain payload cross-checks profiting of the Payload Inspector service from the central AlCa/DB team.
Few of the plots have been already centrally tested in the production environment:

plot_SiStripApvGainsValue: DEMO

plot_SiStripApvGainByRunMeans: DEMO

For the other plots, that are not yet deployed, I've performed the checks recommended in the cmsDbBrowser Twiki, and all the added plots return sensible output:

$ getPayloadData.py --plugin pluginSiStripApvGain_PayloadInspector --plot plot_SiStripApvEndcapMinusGainsByDisk --tag SiStripApvGain_FromParticles_GR10_v1_hlt --time_type Run --iovs '{"start_iov": "286042", "end_iov": "286042"}' --db Prod --test
{"version": "1.0","annotations": {"payload_type":"SiStripApvGain","title":"SiStripApv Gains averages by Endcap (minus) disk","type":"Histo1D","x_label":"Endcap (minus) disk (0-2: TID), (3-11: TEC)","y_label":"average SiStripApv Gain"},"data": [ { "x":0, "y":0.948253 }, { "x":1, "y":0.919545 }, { "x":2, "y":0.936477 }, { "x":3, "y":0.946448 }, { "x":4, "y":0.942019 }, { "x":5, "y":0.942409 }, { "x":6, "y":0.931668 }, { "x":7, "y":0.936945 }, { "x":8, "y":0.933766 }, { "x":9, "y":0.930011 }, { "x":10, "y":0.932945 }, { "x":11, "y":0.945727 }]}
$getPayloadData.py --plugin pluginSiStripApvGain_PayloadInspector --plot plot_SiStripApvEndcapPlusGainsByDisk --tag SiStripApvGain_FromParticles_GR10_v1_hlt --time_type Run --iovs '{"start_iov": "286042", "end_iov": "286042"}' --db Prod --test
{"version": "1.0","annotations": {"payload_type":"SiStripApvGain","title":"SiStripApv Gains averages by Endcap (plus) disk","type":"Histo1D","x_label":"Endcap (plus) disk (0-2: TID), (3-11: TEC)","y_label":"average SiStripApv Gain"},"data": [ { "x":0, "y":0.93174 }, { "x":1, "y":0.929936 }, { "x":2, "y":0.939624 }, { "x":3, "y":0.9445 }, { "x":4, "y":0.935414 }, { "x":5, "y":0.937082 }, { "x":6, "y":0.930777 }, { "x":7, "y":0.933293 }, { "x":8, "y":0.93004 }, { "x":9, "y":0.91023 }, { "x":10, "y":0.925818 }, { "x":11, "y":0.942909 }]}
$getPayloadData.py --plugin pluginSiStripApvGain_PayloadInspector --plot plot_SiStripApvBarrelGainsByLayer --tag SiStripApvGain_FromParticles_GR10_v1_hlt --time_type Run --iovs '{"start_iov": "286042", "end_iov": "286042"}' --db Prod --test
{"version": "1.0","annotations": {"payload_type":"SiStripApvGain","title":"SiStripApv Gains averages by Barrel layer","type":"Histo1D","x_label":"Barrel layer (0-3: TIB), (4-9: TOB)","y_label":"average SiStripApv Gain"},"data": [ { "x":0, "y":1.01021 }, { "x":1, "y":1.00848 }, { "x":2, "y":1.00291 }, { "x":3, "y":0.996242 }, { "x":4, "y":0.953011 }, { "x":5, "y":0.966208 }, { "x":6, "y":0.968372 }, { "x":7, "y":0.957877 }, { "x":8, "y":0.987693 }, { "x":9, "y":0.99202 }]}
$getPayloadData.py --plugin pluginSiStripApvGain_PayloadInspector --plot plot_SiStripApvTOBGainByRunMeans --tag SiStripApvGain_GR10_v1_hlt --time_type Run --iovs '{"start_iov": "1", "end_iov": "124260"}' --db Prod --test
{"version": "1.0","annotations": {"payload_type":"SiStripApvGain","title":"SiStripApv Gains average","type":"History","x_label":"iov_since","y_label":"average Tracker Outer Barrel gain value"},"data": [ { "x":1, "y":1 }, { "x":106945, "y":1.08236 }, { "x":108835, "y":1.08166 }, { "x":111800, "y":1.07971 }, { "x":116635, "y":1.08472 }, { "x":116636, "y":1.08472 }, { "x":117801, "y":1.08485 }, { "x":120696, "y":1.08433 }, { "x":122380, "y":1.08525 }, { "x":124260, "y":1.08543 }]}
$getPayloadData.py --plugin pluginSiStripApvGain_PayloadInspector --plot plot_SiStripApvTIBGainByRunMeans --tag SiStripApvGain_GR10_v1_hlt --time_type Run --iovs '{"start_iov": "1", "end_iov": "124260"}' --db Prod --test
{"version": "1.0","annotations": {"payload_type":"SiStripApvGain","title":"SiStripApv Gains average","type":"History","x_label":"iov_since","y_label":"average Tracker Inner Barrel APV gain value"},"data": [ { "x":1, "y":1 }, { "x":106945, "y":1.07399 }, { "x":108835, "y":1.07037 }, { "x":111800, "y":1.05278 }, { "x":116635, "y":1.05278 }, { "x":116636, "y":1.01806 }, { "x":117801, "y":1.02949 }, { "x":120696, "y":1.02755 }, { "x":122380, "y":1.02888 }, { "x":124260, "y":1.02932 }]}
$getPayloadData.py --plugin pluginSiStripApvGain_PayloadInspector --plot plot_SiStripApvTIDGainByRunMeans --tag SiStripApvGain_GR10_v1_hlt --time_type Run --iovs '{"start_iov": "1", "end_iov": "124260"}' --db Prod --test
{"version": "1.0","annotations": {"payload_type":"SiStripApvGain","title":"SiStripApv Gains average","type":"History","x_label":"iov_since","y_label":"average Tracker Inner Disks APV gain value"},"data": [ { "x":1, "y":1 }, { "x":106945, "y":1.06468 }, { "x":108835, "y":1.06358 }, { "x":111800, "y":1.06228 }, { "x":116635, "y":1.06228 }, { "x":116636, "y":1.06805 }, { "x":117801, "y":1.03418 }, { "x":120696, "y":1.03198 }, { "x":122380, "y":1.03383 }, { "x":124260, "y":1.03559 }]}
$getPayloadData.py --plugin pluginSiStripApvGain_PayloadInspector --plot plot_SiStripApvTECGainByRunMeans --tag SiStripApvGain_GR10_v1_hlt --time_type Run --iovs '{"start_iov": "1", "end_iov": "124260"}' --db Prod --test
{"version": "1.0","annotations": {"payload_type":"SiStripApvGain","title":"SiStripApv Gains average in TEC","type":"History","x_label":"iov_since","y_label":"average Tracker Endcaps APV gain value"},"data": [ { "x":1, "y":1 }, { "x":106945, "y":1.07645 }, { "x":108835, "y":1.07606 }, { "x":111800, "y":1.07534 }, { "x":116635, "y":1.07975 }, { "x":116636, "y":1.07975 }, { "x":117801, "y":1.08001 }, { "x":120696, "y":1.07804 }, { "x":122380, "y":1.07847 }, { "x":124260, "y":1.07928 }]}

attn: @dimattia @arunhep @franzoni

cmsbuild · 2017-06-12T12:17:07Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiStripPlugins
CondCore/Utilities

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @VinInn this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

arunhep · 2017-06-12T12:28:34Z

please test

cmsbuild · 2017-06-12T12:28:56Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20496/console Started: 2017/06/12 14:29

cmsbuild · 2017-06-12T13:40:30Z

+1
Tested at: 9ffb810
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19193/20496/summary.html

cmsbuild · 2017-06-12T13:40:32Z

Comparison job queued.

cmsbuild · 2017-06-12T16:00:13Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19193/20496/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1817858
DQMHistoTests: Total failures: 19279
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1798413
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

franzoni · 2017-06-12T20:45:40Z

hello @mmusich
https://cms-conddb.cern.ch/cmsDbBrowser/payload_inspector/Prod/DEMO
will give you access to all the content of this PR,
merged on top of CMSSW_9_2_3_patch1

mmusich · 2017-06-22T18:05:29Z

%MSG
%MSG-e DQMGenericClient:  DQMGenericClient:postProcessorHLTmuonTracking@endJob  22-Jun-2017 19:14:26 CEST PostGlobalEndRun
 DQMGenericClient::findAllSubdirectories ==> Missing folder HLT/Muon.Tracking/ValidationWRTtp !!!
%MSG

(sigh)

davidlange6 · 2017-06-22T18:15:55Z

please test
(strange)

cmsbuild · 2017-06-22T18:16:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20856/console Started: 2017/06/22 20:16

cmsbuild · 2017-06-22T19:36:55Z

+1
Tested at: d294979
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19193/20856/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e0be6a0
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19193/20856/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19193/20856/git-merge-result

cmsbuild · 2017-06-22T19:36:58Z

Comparison job queued.

cmsbuild · 2017-06-22T22:02:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19193/20856/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1802848
DQMHistoTests: Total failures: 29851
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1772831
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

mmusich · 2017-06-23T13:15:53Z

@ggovi, would you please sign this PR again? W.r.t your last signature I've only removed code that needs to be further reviewed.

ggovi · 2017-06-23T13:43:43Z

+1

cmsbuild · 2017-06-23T13:44:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-06-24T12:06:47Z

+1

mmusich added 8 commits June 7, 2017 11:20

SiStrip Payload inspector revamp

1bc2396

adding history plots for Gain payload inspector

8c7cb38

add method to Histogram1D analogous to TH1::SetBinContent

c8d09cd

add averages per barrel layer

0e41f82

fix FillByBinAndValue to mimick TH1::SetBinContent

18c9a11

add plots for Endcaps

00660eb

add y-axis label in Histogram1D

ca5b1c0

Fix handling of DetIds

9ffb810

cmsbuild added this to the CMSSW_9_2_X milestone Jun 12, 2017

cmsbuild added comparison-pending db-pending orp-pending pending-signatures tests-pending labels Jun 12, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 12, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 12, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 12, 2017

small bug-fix in plot_SiStripApvEndcapPlusGainsByDisk

169f9e2

cmsbuild removed comparison-available tests-approved labels Jun 13, 2017

cmsbuild added the tests-rejected label Jun 22, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jun 22, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 22, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 22, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 22, 2017

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Jun 23, 2017

cmsbuild added orp-approved and removed orp-pending labels Jun 24, 2017

cmsbuild merged commit 9c5c1b5 into cms-sw:master Jun 24, 2017

mmusich deleted the 92X_SiStripPayloadsInpector branch June 27, 2017 12:25

mmusich mentioned this pull request Jul 21, 2017

Deprecation of T**DetId in CalibTracker #19393

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[92X] Add Payload Inspector classes for SiStripApvGains #19193

[92X] Add Payload Inspector classes for SiStripApvGains #19193

mmusich commented Jun 12, 2017 •

edited

cmsbuild commented Jun 12, 2017

arunhep commented Jun 12, 2017

cmsbuild commented Jun 12, 2017 •

edited

cmsbuild commented Jun 12, 2017

cmsbuild commented Jun 12, 2017

cmsbuild commented Jun 12, 2017

franzoni commented Jun 12, 2017

mmusich commented Jun 22, 2017

davidlange6 commented Jun 22, 2017

cmsbuild commented Jun 22, 2017 •

edited

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

mmusich commented Jun 23, 2017

ggovi commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

davidlange6 commented Jun 24, 2017

[92X] Add Payload Inspector classes for SiStripApvGains #19193

[92X] Add Payload Inspector classes for SiStripApvGains #19193

Conversation

mmusich commented Jun 12, 2017 • edited

cmsbuild commented Jun 12, 2017

arunhep commented Jun 12, 2017

cmsbuild commented Jun 12, 2017 • edited

cmsbuild commented Jun 12, 2017

cmsbuild commented Jun 12, 2017

cmsbuild commented Jun 12, 2017

franzoni commented Jun 12, 2017

mmusich commented Jun 22, 2017

davidlange6 commented Jun 22, 2017

cmsbuild commented Jun 22, 2017 • edited

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

mmusich commented Jun 23, 2017

ggovi commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

davidlange6 commented Jun 24, 2017

mmusich commented Jun 12, 2017 •

edited

cmsbuild commented Jun 12, 2017 •

edited

cmsbuild commented Jun 22, 2017 •

edited