initial pr for the sistrip control view dqm plots #19204
Conversation
|
A new Pull Request was created by @gouskos for master. It involves the following packages: DQM/SiStripMonitorTrack @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
hello @gouskos thanks for this new PR - When making a PR, a summary of what the PR does, add , new functionality etc is always welcome [ see the box above you can edit , where iy is written No description provided , better to provide a description instead ] |
|
OK sorry - thought it was clear from the title. This PR produces a set of DQM plots for the SiStrip subdetector. The plots currently in DQM are organized based on the "Mechanical View" [i.e. physical subdetectors: TEC+/-, TID, TOB, TIB]. This is not always very useful to spot issues on the Control side. Hence I ve put a new dir in the SiSTrip DQM directory that is organized based on the SiStrip partiions seen in the DAQ [TEC+, TEC-, TOB, TIB/TOB] The first set of plots inlcudes: S/N for each TTC partition, FECSlot vs FEC Ring and FECCratevsFECSlot |
|
thanks but put this description in see the description box above you can edit [where it is written No description provided , edit and replace by this description ] |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
| if( !tracks.isValid() ) return false; | ||
|
|
||
| // loop over the tracks | ||
| for( reco::TrackCollection::const_iterator track = tracks->begin(); |
There was a problem hiding this comment.
hi @gouskos - please use
for ( const auto & track : tracks) {...
}
gouskos
force-pushed
the
sistrip-conview-92v2
branch
from
7e95b7d
to
d328475
Compare
|
Pull request #19204 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
|
Hi @kpedro88 ; it looks much better now - thanks a lot for your help! I will check if the changes I made to address David Lange's comments are in |
|
Hi @dmitrijus and @davidlange6 : @gouskos just told me that the comments should have been adressed, could you please retrigger the tests ? Many thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
Hi @dmitrijus can you please review this PR after the updates ? |
|
merge |
This PR produces a set of DQM plots for the SiStrip subdetector. The plots currently in DQM are organized based on the "Mechanical View" [i.e. physical subdetectors: TEC+/-, TID, TOB, TIB]. This is not always very useful to spot issues on the Control side. Hence I ve put a new dir in the SiSTrip DQM directory that is organized based on the SiStrip partiions seen in the DAQ [TEC+, TEC-, TOB, TIB/TOB] The first set of plots inlcudes: S/N for each TTC partition, FECSlot vs FEC Ring and FECCratevsFECSlot