Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary map hotfixes #19219

Merged
merged 4 commits into from Jun 19, 2017
Merged

Summary map hotfixes #19219

merged 4 commits into from Jun 19, 2017

Conversation

leggat
Copy link
Contributor

@leggat leggat commented Jun 14, 2017

Updates to the summary maps:

  1. Grand Summary Map renamed to reportSummaryMap. This is achieved by hard coding the grand summary (as it should always be there) and removing it from the python configuration file. This also removes the checks for "Grand" later in the code.
  2. Adding in a float ME 'reportSummary' to the EventInfo directory. This contains the mean of the non-negative bins in the reportSummaryMap.
  3. Moved ROC counting trend plots from the EventInfo directory to the PixelPhase1/ directory so they can actually be found.

…o be picked up automatically by the GUI. 2) reportSummary ME added to EventInfo directory. The mean value of the bins the reportSummaryMap. 3) Moved roc counting plots to PixelPhase1/ directory.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @leggat for master.

It involves the following packages:

DQM/SiPixelPhase1Summary

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@vanbesien
Copy link
Contributor

Don't forget that if you change the location and name of your summary plot, you also need to update your layouts in the GUI.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20604/console Started: 2017/06/15 17:10

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19219/20604/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1803161
  • DQMHistoTests: Total failures: 29853
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1773142
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ffecb3b into cms-sw:master Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants