Deprecating T(IB|OB|ID|EC)DetId types in DPGAnalysis/SiStripTools

[vidalm]

cc @alesaggio @OlivierBondu @pieterdavid

Removing commented code with T(IB|OB|ID|EC)DetId types (cc @boudoul @mmusich)

Removing the deprecated
DataFormats/SiStripDetId/interface/T(IB|OB|ID|EC)DetId.h

and replacing it with
DataFormats/TrackerCommon/interface/TrackerTopology.h

[cmsbuild]

A new Pull Request was created by @vidalm (Miguel Vidal) for master.

It involves the following packages:

DPGAnalysis/SiStripTools

@cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@ebrondol, @threus, @venturia this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[mmusich]

Can someone please start the integration tests here?
Thanks

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20632/console Started: 2017/06/16 10:28

[cmsbuild]

-1

Tested at: bbccef2

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19221/20632/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step1

DAS Error

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[davidlange6]

merge

[mmusich]

tracked at #19398