Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu 2017 v1.1 #19235

Merged
merged 7 commits into from Jun 26, 2017
Merged

HLT menu 2017 v1.1 #19235

merged 7 commits into from Jun 26, 2017

Conversation

Martin-Grunewald
Copy link
Contributor

@Martin-Grunewald Martin-Grunewald commented Jun 15, 2017

HLT menu 2017 v1.1
Based on 923.
rebased to CMSSW_9_2_X_2017-06-22-2300 (23 June 2017)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @geoff-smith, @jalimena this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20583/console Started: 2017/06/15 08:44

@cmsbuild
Copy link
Contributor

-1

Tested at: 19d80d9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19235/20583/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step2
runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step2
runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

  • AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/nweek-02476/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-14-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jun 15 09:25:16 2017-date Thu Jun 15 09:20:42 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02476/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-14-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jun 15 09:28:49 2017-date Thu Jun 15 09:20:59 2017 s - exit: 18688

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

Pull request #19235 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20589/console Started: 2017/06/15 10:52

@Martin-Grunewald
Copy link
Contributor Author

addOn tests should be cured by adding missing OnLine_HLT_PRef.py file.

relval tests need an update of GTs for the L1T menu used by the updated HLT menu,
requested here: https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/3001.html

@cmsbuild
Copy link
Contributor

-1

Tested at: 3cc154a

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
41495b4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19235/20589/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19235/20589/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19235/20589/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step2
runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step2
runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
41495b4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19235/20589/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19235/20589/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@smuzaffar smuzaffar removed this from the CMSSW_9_2_X milestone Jun 26, 2017
@franzoni
Copy link

@rekovic reported at AlCa/Db meeting of reproducing locally the problem and indeed ZeroBias not firing. The origin is under investigation , an ETA for the fix in the making.

Given the other parallel condition integration fronts
what we propose is to sign this PR and have it merged even though the L1 menu is sub-performant. Benefits are that we do get the HLT updates and we can in parallel integrate PF calibrations.
We'll provide a GT update with the fix to the L1T menu as soon as available.

@Martin-Grunewald @rekovic @arunhep @kkotov
agreed to this proposal.

@franzoni
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a44f5ad into cms-sw:master Jun 26, 2017
@mmusich
Copy link
Contributor

mmusich commented Jun 26, 2017

@franzoni

Given the other parallel condition integration fronts
what we propose is to sign this PR and have it merged even though the L1 menu is sub-performant. Benefits are that we do get the HLT updates and we can in parallel integrate PF calibrations.
We'll provide a GT update with the fix to the L1T menu as soon as available.

I hope this enters the next release, otherwise it will be difficult to validate on the Strips side @boudoul

@fwyzard
Copy link
Contributor

fwyzard commented Jun 26, 2017

Hi people,
sorry, but I miss one detail: which workflow was working before, and is broken by this PR ?

@fwyzard
Copy link
Contributor

fwyzard commented Jun 26, 2017

Nevermind, Vladimir pointed me to 10024.0 .

@Martin-Grunewald
Copy link
Contributor Author

@davidlange6
Is this PR integrated in 92X or 93X or both?

@fwyzard
Copy link
Contributor

fwyzard commented Jun 26, 2017 via email

@Martin-Grunewald
Copy link
Contributor Author

thanks!

@rekovic
Copy link
Contributor

rekovic commented Jun 26, 2017

Looking at this issue and keeping track of it here
cms-l1t-offline#571

@franzoni
Copy link

I hope this enters the next release, otherwise it will be difficult to validate on the Strips side @boudoul

Alca will integrate the fix as soon as available, if, as it seems to date, the origin is the l1 menu
ETA will be provided by L1T team as soon as they'll have it
The goal is for the moment still having L1T and hlt updated to 2017 for the V1 dog-pog mc campaign

@hatakeyamak
Copy link
Contributor

@deguio can you confirm that this is not part of the hcal validation suite?:

https://github.com/cms-sw/cmssw/blob/CMSSW_9_2_X/Validation/GlobalRecHits/src/GlobalRecHitsAnalyzer.cc
is not a part of the HCAL release validation. I am not sure who uses it.

@Dr15Jones
Copy link
Contributor

I think that this pull request may be what is causing the RleVal failure for 1325.0.
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc530/CMSSW_9_3_X_2017-06-26-2300/pyRelValMatrixLogs/run/1325.0_TTbar_13+TTbar_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15+ALCATTUP15/step5_TTbar_13+TTbar_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15+ALCATTUP15.log

The failure does not happen in 9_2 but does start with the first 9_3. Can anyone confirm or refute the connection?

@Martin-Grunewald
Copy link
Contributor Author

Correct - that wf uses HLT:@relval2016 which now redirects to the Fake2 menu containing just a few basic paths. BTW, the filter throwing the exception in question can be configured to print a MessageLogger LogInfo message rather than throw an exception; I suggest doing so, or of course updating the requested pattern "AlCa_EcalPhiSym*"

@Martin-Grunewald
Copy link
Contributor Author

L1_ZeroBias fix - PR is #19492

@arunhep
Copy link
Contributor

arunhep commented Jun 30, 2017

Summary of changes in Global Tags

RunII data

Upgrade

@Martin-Grunewald Martin-Grunewald deleted the HLT_2017_V1p1 branch September 7, 2017 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet