Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix T0 DQM crash. Remove online uGT DQM module from the offline #19241

Conversation

thomreis
Copy link
Contributor

Remove the online uGT DQM module from the offline sequence to avoid crashes at the T0.

The large histograms used too much memory and caused crashes.
https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1532/1/1.html

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@kreczko, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

@dmitrijus @davidlange6 This is not yet approved by the uGT folks and should only be merged after the green light by them or in case of emergency.

@davidlange6
Copy link
Contributor

davidlange6 commented Jun 15, 2017 via email

@thomreis
Copy link
Contributor Author

The thread name in the HN link posted above is "Jobs Exceeding maxRSS Observed in Replay for 923p1".

@dmitrijus
Copy link
Contributor

plase test

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20593/console Started: 2017/06/15 16:13

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@thomreis
Copy link
Contributor Author

@dmitrijus @davidlange6 This got the green light from @apana and Manfred. They are OK to remove the module from offline.

@rekovic can you please take a look and sign this?

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19241/20593/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1818986
  • DQMHistoTests: Total failures: 34616
  • DQMHistoTests: Total nulls: 70
  • DQMHistoTests: Total successes: 1784134
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Jun 19, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a6aa2e4 into cms-sw:master Jun 19, 2017
@thomreis thomreis deleted the prevent_ugt_offline_dqm_t0_crash_by_removing_ugt_online_plots branch July 12, 2017 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants