Fix includes in DigiCollectionProfiler.h #19289
Conversation
|
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
|
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: DPGAnalysis/SiStripTools @cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Teemperor
force-pushed
the
FixIncludesDigiCollectionProfiler.h
branch
from
b858901
to
065137a
Compare
We replace the forward declarations of TH1F, TH2F and TProfile with actual includes as we call method from these classes in the lines 87-89, so a forward declaration no longer guarantees that this header compiles. The same goes for ParameterSet in line 56. For SiStripCluster we add the proper include as we use it in line 146.
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
merge |
|
Comparison is ready Comparison Summary:
|
We replace the forward declarations of TH1F, TH2F and TProfile with
actual includes as we call method from these classes in the lines
87-89, so a forward declaration no longer guarantees that this
header compiles. The same goes for ParameterSet in line 56.
For SiStripCluster we add the proper include as we use it in line 146.