Fix includes/fwd decls in Fireworks/Core #19332
Conversation
|
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
|
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: Fireworks/Core @cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
We have to forward declare TEveWindowSlot/TEveElement because we reference pointers to those types in the respective headers. We have to include Rtypes.h to get Color_t in FWDetailViewBase.h and FWModelExpressionSelector.h. In FWViewBase.h we have to include Rtypes.h for Int_t. In FWDetailViewManager.h/FWInteractionList.h we have to include <vector> because we use std::vector there.
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-approved
and removed
comparison-pending
tests-started
labels
|
merge |
We have to forward declare TEveWindowSlot/TEveElement because
we reference pointers to those types in the respective headers.
We have to include Rtypes.h to get Color_t in FWDetailViewBase.h
and FWModelExpressionSelector.h. In FWViewBase.h we have to
include Rtypes.h for Int_t.
In FWDetailViewManager.h/FWInteractionList.h we have to
include because we use std::vector there.