New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix includes in DEutils.h #19342
Fix includes in DEutils.h #19342
Conversation
We need to include MessageLogger.h here because we use edm::LogError. We also need to include iomanip for the definition of std::setw that we use in this file, as otherwise it won't compile on its own.
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: L1Trigger/HardwareValidation @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
We need to include MessageLogger.h here because we use edm::LogError.
We also need to include iomanip for the definition of std::setw that
we use in this file, as otherwise it won't compile on its own.