New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward declare ClusterSHape in ElectronSelector.h #19351
Forward declare ClusterSHape in ElectronSelector.h #19351
Conversation
We use a pointer to this type in this header, but we don't include the relevant headers, so this file fails to compile on its own. As we don't need the definition here, we just forward declare it.
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: PhysicsTools/PatUtils @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
We use a pointer to this type in this header, but we don't include
the relevant headers, so this file fails to compile on its own.
As we don't need the definition here, we just forward declare it.