removing useless files (old phase2 pixel clusters ) #19360
Conversation
|
A new Pull Request was created by @boudoul (boudoul) for master. It involves the following packages: RecoLocalTracker/Phase2ITPixelClusterizer @perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
merge |
|
hi @boudoul - looks like there are problems from this PR: File "/cvmfs/cms-ib.cern.ch/nweek-02477/slc7_amd64_gcc630/cms/cmssw/CMSSW_9_2_X_2017-06-21-1100/python/RecoLocalTracker/Configuration/RecoLocalTracker_cff.py", line 21, in |
|
whoopsie , will look |
|
On 6/21/17 6:54 AM, David Lange wrote:
hi @boudoul <https://github.com/boudoul> - looks like there are problems
from this PR:
File
"/cvmfs/cms-ib.cern.ch/nweek-02477/slc7_amd64_gcc630/cms/cmssw/CMSSW_9_2_X_2017-06-21-1100/python/RecoLocalTracker/Configuration/RecoLocalTracker_cff.py",
line 21, in
from
RecoLocalTracker.Phase2ITPixelClusterizer.Phase2ITPixelClusterizer_cfi
import *
ImportError: No module named
Phase2ITPixelClusterizer.Phase2ITPixelClusterizer_cfi
RecoLocalTracker/Configuration/RecoLocalTracker_cff.py is included in
all jenkins workflows.
I thought that this kind of issue was fixed with all the "poison"
directories and related ways.
Are we still stuck to need a full IB to test file removal?
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19360 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcblTIDeIgLP4AAryUOLTjWzxc3LYFks5sGSCjgaJpZM4N-PuQ>.
|
|
This broke the IB because the deleted files are being imported: |
|
On 6/21/17 7:02 AM, Chris Jones wrote:
This broke the IB because the deleted files are being imported:
https://github.com/cms-sw/cmssw/blob/master/RecoLocalTracker/Configuration/python/RecoLocalTracker_cff.py#L21
does this mean that the build system can not detect file removal until
full release build?
I thought this is handled and didn't check with git grep
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19360 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbmHGnLlsKpmNL9LewA1G2sYr4TObks5sGSJagaJpZM4N-PuQ>.
|
|
@smuzaffar you would know better about how the build system is meant to handle removed python files. |
|
The trickier issue is directory removal, which indeed I thought that Shahzad had addressed, but there must be a corner case left to find. python file removal is easily caught as python path works on directories.
… On Jun 21, 2017, at 4:13 PM, Slava Krutelyov ***@***.***> wrote:
On 6/21/17 7:02 AM, Chris Jones wrote:
> This broke the IB because the deleted files are being imported:
> https://github.com/cms-sw/cmssw/blob/master/RecoLocalTracker/Configuration/python/RecoLocalTracker_cff.py#L21
does this mean that the build system can not detect file removal until
full release build?
I thought this is handled and didn't check with git grep
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#19360 (comment)>, or
> mute the thread
> <https://github.com/notifications/unsubscribe-auth/AEdcbmHGnLlsKpmNL9LewA1G2sYr4TObks5sGSJagaJpZM4N-PuQ>.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@davidlange6 , @Dr15Jones and @slava77 : build system only takes care of deleted python files but there is no protection for python files when either python directory or full package is deleted. Last time I added protection for edm plugins deleted in scram dev area (either due to BuildFile.xml changes or removal of package) via poisoned edm cache. I will add some protection for deleted python dirs too. |
new tag generates python/package/__init__.py for all the packages (even if there is no src/package/python directory). This fixes the issue we have seen due to PR cms-sw/cmssw#19360 where RecoLocalTracker/Phase2ITPixelClusterizer/python was deleted and we only noticed the problem when full release was built. New build rules also create python/package/__init__.py for deleted packages
|
On 6/22/17 12:20 AM, Malik Shahzad Muzaffar wrote:
@davidlange6 <https://github.com/davidlange6> , @Dr15Jones
<https://github.com/dr15jones> and @slava77 <https://github.com/slava77>
: build system only take care of deleted python files but there is no
protection for python files when either python directory or full package
is deleted. Last time I added protection for edm plugins deleted in
scram dev area (either due to BuildFile.xml changes or removal of
package) via poisoned edm cache.
I will add some protection for deleted python dirs too.
Thank you.
If this becomes too complicated, we should at least make the package
removal trigger a full build.
In this case the problem in workflows did not show up until there was a
full build.
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19360 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbnNT0l2BJSHxZDBedcWkgWt7gZgcks5sGhWygaJpZM4N-PuQ>.
|
|
I already have a new cmssw-config tag (being tested here #19360) which should fix this. After successful testing in DEVEL IBs (for a week), I will include it in normal IBs. |
|
thank you everybody and sorry for the inconvenince with the broken IBs ... I should have myself caught this while preparing the PR .. |
new tag generates python/package/__init__.py for all the packages (even if there is no src/package/python directory). This fixes the issue we have seen due to PR cms-sw/cmssw#19360 where RecoLocalTracker/Phase2ITPixelClusterizer/python was deleted and we only noticed the problem when full release was built. New build rules also create python/package/__init__.py for deleted packages
Those files were originally developed for the pixel phase2 clusters but are eventually not used and for sure obsolete , i'm removing to clean and prevent any uaage of them by mistake .