Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Geometry Aligner Header #19416

Merged
merged 1 commit into from Jun 26, 2017

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jun 23, 2017

  • Move a single header file in another package to allow scram check and report correct source code dependency

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Alignment/CommonAlignmentMonitor
Alignment/CommonAlignmentProducer
Alignment/LaserAlignment
Alignment/MuonAlignment
Alignment/OfflineValidation
Alignment/SurveyAnalysis
Alignment/TrackerAlignment
Geometry/CSCGeometryBuilder
Geometry/CommonTopologies
Geometry/DTGeometryBuilder
Geometry/TrackerGeometryBuilder
Geometry/TrackingGeometryAligner

@ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @makortel, @abbiendi, @tocheng, @VinInn, @ptcox, @jhgoh, @tlampen, @mschrode, @ebrondol, @trocino, @mmusich, @venturia this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented Jun 23, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 23, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20890/console Started: 2017/06/23 17:02

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ianna
Copy link
Contributor Author

ianna commented Jun 23, 2017

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19416/20890/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1802882
  • DQMHistoTests: Total failures: 15035
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1787681
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Jun 26, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 4fd75fa into cms-sw:master Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants