Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup uninitialized reads or conditions and leaks #19426

Merged

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jun 25, 2017

these were collected from the valgrind report for "step3" run with a 2017 workflow with PU (10211).

The change in DQM/SiPixelPhase1Common/interface/GeometryInterface.h actually didn't fix anything, but it still looks useful.

Local short matrix run shows no differences.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

DQM/SiPixelPhase1Common
DQM/SiStripMonitorTrack
HeavyFlavorAnalysis/Onia2MuMu
PhysicsTools/MVAComputer
RecoLocalCalo/EcalRecProducers
SimMuon/MCTruth
Validation/EcalDigis

@perrotta, @civanch, @monttj, @vazzolini, @kmaeshima, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@HuguesBrun, @hdelanno, @imarches, @trocino, @acaudron, @abbiendi, @jhgoh, @argiro, @calderona, @mverzett, @JyothsnaKomaragiri, @fioriNTU, @threus, @idebruyn, @ferencek, @battibass, @pvmulder this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Jun 25, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20911/console Started: 2017/06/25 21:07

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19426/20911/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1799539
  • DQMHistoTests: Total failures: 15026
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1784347
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@civanch
Copy link
Contributor

civanch commented Jun 26, 2017

+1

@slava77
Copy link
Contributor Author

slava77 commented Jun 27, 2017

+1

for #19426 ff0e38f

  • jenkins tests pass and comparisons show no differences in reco and one (expected) change in ECAL DQM

wf25202_zserrtype1

this histogram now shows properly values per event (compared to a cumulative value summing over all events, with occasionally uninitialized initial value)

@davidlange6
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants