New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup uninitialized reads or conditions and leaks #19426
cleanup uninitialized reads or conditions and leaks #19426
Conversation
…lar ZS error conters were since initial commit 8 years ago
…ing for it was missing since original commit in fc78f7e); this is fixing an issue reading uninitialized values reported by valgrind
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages: DQM/SiPixelPhase1Common @perrotta, @civanch, @monttj, @vazzolini, @kmaeshima, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
merge |
these were collected from the valgrind report for "step3" run with a 2017 workflow with PU (10211).
The change in DQM/SiPixelPhase1Common/interface/GeometryInterface.h actually didn't fix anything, but it still looks useful.
Local short matrix run shows no differences.