Track cuts redone #19428

fioriNTU · 2017-06-26T15:27:07Z

This PR replicates the #19194 that has been merged and then reverted before 9_2_4

A protection against crashes has been added following indications of @davidlange6 and @VinInn

…(5*1600=8000 bins added)

cmsbuild · 2017-06-26T15:27:33Z

A new Pull Request was created by @fioriNTU for master.

It involves the following packages:

DQM/SiPixelPhase1Clusters
DQM/SiPixelPhase1Config
DQM/SiPixelPhase1RecHits
DQM/SiPixelPhase1TrackClusters
DQM/SiPixelPhase1TrackEfficiency
DQM/SiPixelPhase1TrackResiduals

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @hdelanno this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

dmitrijus · 2017-06-26T15:47:51Z

please test

cmsbuild · 2017-06-26T15:48:07Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20919/console Started: 2017/06/26 17:48

VinInn · 2017-06-26T15:55:11Z

DQM/SiPixelPhase1TrackClusters/src/SiPixelPhase1TrackClusters.cc

@@ -142,6 +161,7 @@ void SiPixelPhase1TrackClusters::analyze(const edm::Event& iEvent, const edm::Ev
        histo[ONTRACK_SIZE      ].fill(double(cluster.size()  ), id, &iEvent);
        histo[ONTRACK_POSITION_B].fill(clustgp.z(),   clustgp.phi(),   id, &iEvent);
        histo[ONTRACK_POSITION_F].fill(clustgp.x(),   clustgp.y(),     id, &iEvent);
+	histo[ONTRACK_SIZE_VS_ETA].fill(etatk[key], cluster.sizeY(), id, &iEvent);


strickly speaking one should take into account bigpixel for instance as
auto sizeY = cluster.sizeY();
if (topol.containsBigPixelInY(cluster.minPixelCol(), cluster.maxPixelCol()) ) sizeY+=1;
we need to ask confirmation to Pixels guys....

VinInn · 2017-06-26T15:56:13Z

DQM/SiPixelPhase1TrackClusters/src/SiPixelPhase1TrackClusters.cc

 }

 void SiPixelPhase1TrackClusters::analyze(const edm::Event& iEvent, const edm::EventSetup& iSetup) {

+  if (! (histo.size() > ONTRACK_SIZE_VS_ETA)) return;


this is a QUICK fix.
we may have to issue a LogWarning in future (actually an assert)

cmsbuild · 2017-06-26T17:49:13Z

-1

Tested at: 94ba37c

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
fc51b5b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19428/20919/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19428/20919/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19428/20919/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full2015Data --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Mon Jun 26 19:25:42 2017-date Mon Jun 26 19:17:00 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02478/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-06-26-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Mon Jun 26 19:25:42 2017-date Mon Jun 26 19:17:00 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Mon Jun 26 19:25:42 2017-date Mon Jun 26 19:17:00 2017 s - exit: 21504
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02478/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-06-26-1100/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Mon Jun 26 19:33:19 2017-date Mon Jun 26 19:25:51 2017 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Mon Jun 26 19:34:07 2017-date Mon Jun 26 19:25:56 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02478/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-06-26-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Mon Jun 26 19:34:07 2017-date Mon Jun 26 19:25:56 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Mon Jun 26 19:34:07 2017-date Mon Jun 26 19:25:56 2017 s - exit: 21504

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
fc51b5b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19428/20919/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19428/20919/git-merge-result

cmsbuild · 2017-06-26T17:49:16Z

Comparison job queued.

fioriNTU · 2017-06-26T19:19:17Z

@dmitrijus @davidlange6 what shall I do to fix this? A rebase?

cmsbuild · 2017-06-26T20:00:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19428/20919/summary.html

Comparison Summary:

You potentially added 45 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1813728
DQMHistoTests: Total failures: 19039
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1794523
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

fioriNTU · 2017-06-27T12:08:25Z

@dmitrijus and @davidlange6 sorry to insist, but I need help in fixing this. What I did is to cherry-pick my commits from the previous PR and add the Vincenzo's suggestions on top of it.
Is there anything wrong on this procedure?

davidlange6 · 2017-06-27T16:24:04Z

I think the failures are not related

davidlange6 · 2017-06-27T16:24:22Z

please test

cmsbuild · 2017-06-27T19:46:21Z

+1
Tested at: 94ba37c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19428/20955/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3b01ccc
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19428/20955/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19428/20955/git-merge-result

cmsbuild · 2017-06-27T19:46:24Z

Comparison job queued.

cmsbuild · 2017-06-27T21:17:15Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19428/20955/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1754227
DQMHistoTests: Total failures: 4043
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1750018
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

boudoul · 2017-06-28T15:42:14Z

@dmitrijus , could you please consider this PR ? thanks

boudoul · 2017-07-03T08:51:47Z

@dmitrijus , could you please consider this PR ? thanks

boudoul · 2017-07-04T14:20:48Z

@dmitrijus , could you please consider this PR ? thanks

boudoul · 2017-07-05T08:23:06Z

@dmitrijus , could you please consider this PR ? thanks

VinInn · 2017-07-05T08:26:08Z

I would like to add stuff to this, possibly in time for next round of data taking...
This PR shall be merged last Sunday...

VinInn · 2017-07-06T05:18:54Z

The integration of this PR is becoming extremely urgent

dmitrijus · 2017-07-06T09:05:28Z

+1

cmsbuild · 2017-07-06T09:06:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-07-06T11:57:01Z

DQM/SiPixelPhase1RecHits/src/SiPixelPhase1RecHits.cc

@@ -41,8 +42,16 @@ void SiPixelPhase1RecHits::analyze(const edm::Event& iEvent, const edm::EventSet
  iEvent.getByToken( srcToken_, tracks);
  if (!tracks.isValid()) return;

+  edm::Handle<reco::VertexCollection> vertices;


hi @fioriNTU - please do the getByToken (and the consumes above) only if applyVertexCut_ is true
Also replace vertices->size()==0 by vertices->empty()

VinInn · 2017-07-06T12:02:54Z

@davidlange6 , please integrate
as soon as in IB I will clean it up and add more useful thinks...

davidlange6 · 2017-07-06T12:05:46Z

+1
ok, sounds fine to me.

threus · 2017-07-11T12:32:16Z

@fioriNTU could you please back port this PR to 92X? It is needed for the online DQM, otherwise your changes don't get merged into the current production branch.
Thanks

fioriNTU added 5 commits June 26, 2017 12:31

adding a simple track cut

7dc633f

implementing David suggestions

79d0797

Change some plots to TProfiles and add 5 histos for OnTrack Clusters …

f46fd43

…(5*1600=8000 bins added)

possible fix to failing tests

b60327f

adding simple track cuts

94ba37c

cmsbuild added this to the CMSSW_9_3_X milestone Jun 26, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jun 26, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 26, 2017

VinInn reviewed Jun 26, 2017

View reviewed changes

cmsbuild added tests-rejected and removed tests-started labels Jun 26, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 26, 2017

cmsbuild removed comparison-available tests-rejected labels Jun 27, 2017

smuzaffar modified the milestone: CMSSW_9_3_X Jun 27, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 27, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 27, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 6, 2017

davidlange6 reviewed Jul 6, 2017

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Jul 6, 2017

cmsbuild merged commit 30de1f6 into cms-sw:master Jul 6, 2017

fioriNTU mentioned this pull request Jul 11, 2017

Track cuts redone backport #19683

Merged

folguera mentioned this pull request Jul 14, 2017

Adding inactive hit maps #19740

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Track cuts redone #19428

Track cuts redone #19428

fioriNTU commented Jun 26, 2017

cmsbuild commented Jun 26, 2017

dmitrijus commented Jun 26, 2017

cmsbuild commented Jun 26, 2017 •

edited

VinInn Jun 26, 2017

VinInn Jun 26, 2017

cmsbuild commented Jun 26, 2017

cmsbuild commented Jun 26, 2017

fioriNTU commented Jun 26, 2017

cmsbuild commented Jun 26, 2017

fioriNTU commented Jun 27, 2017

davidlange6 commented Jun 27, 2017

davidlange6 commented Jun 27, 2017

cmsbuild commented Jun 27, 2017

cmsbuild commented Jun 27, 2017

cmsbuild commented Jun 27, 2017

boudoul commented Jun 28, 2017

boudoul commented Jul 3, 2017

boudoul commented Jul 4, 2017

boudoul commented Jul 5, 2017

VinInn commented Jul 5, 2017 •

edited

VinInn commented Jul 6, 2017

dmitrijus commented Jul 6, 2017

cmsbuild commented Jul 6, 2017

davidlange6 Jul 6, 2017

VinInn commented Jul 6, 2017

davidlange6 commented Jul 6, 2017

threus commented Jul 11, 2017

Track cuts redone #19428

Track cuts redone #19428

Conversation

fioriNTU commented Jun 26, 2017

cmsbuild commented Jun 26, 2017

dmitrijus commented Jun 26, 2017

cmsbuild commented Jun 26, 2017 • edited

VinInn Jun 26, 2017

Choose a reason for hiding this comment

VinInn Jun 26, 2017

Choose a reason for hiding this comment

cmsbuild commented Jun 26, 2017

cmsbuild commented Jun 26, 2017

fioriNTU commented Jun 26, 2017

cmsbuild commented Jun 26, 2017

fioriNTU commented Jun 27, 2017

davidlange6 commented Jun 27, 2017

davidlange6 commented Jun 27, 2017

cmsbuild commented Jun 27, 2017

cmsbuild commented Jun 27, 2017

cmsbuild commented Jun 27, 2017

boudoul commented Jun 28, 2017

boudoul commented Jul 3, 2017

boudoul commented Jul 4, 2017

boudoul commented Jul 5, 2017

VinInn commented Jul 5, 2017 • edited

VinInn commented Jul 6, 2017

dmitrijus commented Jul 6, 2017

cmsbuild commented Jul 6, 2017

davidlange6 Jul 6, 2017

Choose a reason for hiding this comment

VinInn commented Jul 6, 2017

davidlange6 commented Jul 6, 2017

threus commented Jul 11, 2017

cmsbuild commented Jun 26, 2017 •

edited

VinInn commented Jul 5, 2017 •

edited