Add track selection MVA plots to tracking DQM #19481
Conversation
To avoid hitting the 255 arguments limit with the upcoming
developments. (I know, I could switch to **dict([("key", "value")])
but I'd rather not overhaul the main configuration file).
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: DQM/TrackingMonitor @perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
@makortel : can you point me to one of the new histos in any of the DQM plots produced during the jenkins tests of this PR? I was curious to see some, but I am not able to retrieve them in the trees... |
|
@perrotta The added histograms can be found from For an example, here are for initialStep (from 10024.0) the distribution of the MVA variable |
|
Thank you @makortel ! I couldn't find the exact folder (and I was too lazy to dig into the configuration and look for it...) |
|
+1
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
This PR adds distributions and profiles vs. pT and eta of the track selection MVA output for each tracking iteration with an MVA track selection. For the cases where an iteration makes use of multiple MVA selectors (as in phase0), a similar logic is used as in MultiTrackValidator, i.e.
I also removed two obsolete configuration parameters (OutputMEsInRootFile and OutputFileName) to not hit the 255 parameter limit (and needing to modify the entire TrackingMonitor_cfi).
Tested in CMSSW_9_2_3. Expecting new histograms in phase0 and phase1, and no changes in phase2.
@rovere @VinInn @mtosi @hajohajo