Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr92x L1T fix L1T_ZeroBias not firing in RelVal MC. #19494

Merged
merged 1 commit into from Jul 6, 2017

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Jun 30, 2017

backport of #19492

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_9_2_X.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor Author

rekovic commented Jun 30, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21025/console Started: 2017/06/30 16:47

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19494/21025/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1813730
  • DQMHistoTests: Total failures: 15029
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1798535
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@rekovic
Copy link
Contributor Author

rekovic commented Jul 3, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@rekovic
Copy link
Contributor Author

rekovic commented Jul 3, 2017

93x PR #19492 has been merged, since three days ago.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8443a0b into cms-sw:CMSSW_9_2_X Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants