Add first hit from HitPattern in PackedCandidates with high level track details #19509

arizzi · 2017-07-03T06:52:22Z

This adds the first hit layer/substructure information for PackedCandidates passing the high level track details (i.e.> 0.95GeV at the moment)
It also removes the storage of case the lostHits = -1 (validHitInFirstPixelBarrelLayer) as the information is redundant (at least for tracks where the first hit is in PXB1, perhaps not true for some loopers... )

The size increase should be ~ 60-100 bytes/event

@gpetruc

…producer

cmsbuild · 2017-07-03T06:52:40Z

A new Pull Request was created by @arizzi for master.

It involves the following packages:

DataFormats/PatCandidates
DataFormats/TrackReco
PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @ahinzmann, @seemasharmafnal, @mmarionncern, @imarches, @makortel, @acaudron, @jdolen, @ferencek, @VinInn, @nhanvtran, @gkasieczka, @schoef, @ebrondol, @JyothsnaKomaragiri, @mverzett, @cbernet, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

perrotta · 2017-07-03T07:03:53Z

please test

cmsbuild · 2017-07-03T07:04:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21069/console Started: 2017/07/03 09:04

arizzi · 2017-07-03T09:26:00Z

probably need to revert last commit or at least adjust it as we store that info for all tracks...

cmsbuild · 2017-07-03T09:54:02Z

-1

Tested at: 93227d0

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b1580cd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19509/21069/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19509/21069/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19509/21069/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test testAlignmentOfflineValidation had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b1580cd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19509/21069/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19509/21069/git-merge-result

cmsbuild · 2017-07-03T09:54:05Z

Comparison job queued.

arizzi · 2017-07-03T09:57:04Z

the broken unit test seem unrelated with this PR

cmsbuild · 2017-07-03T13:12:14Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19509/21069/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 22 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1756063
DQMHistoTests: Total failures: 29370
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1726527
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

cmsbuild · 2017-07-04T12:16:06Z

Pull request #19509 was updated. @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please check and sign again.

cmsbuild · 2017-07-10T16:21:30Z

-1

Tested at: 15490d4

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0619998
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19509/21305/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19509/21305/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19509/21305/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Mon Jul 10 17:49:02 2017-date Mon Jul 10 17:47:37 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 17:49:02 2017-date Mon Jul 10 17:47:37 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 17:49:02 2017-date Mon Jul 10 17:47:37 2017 s - exit: 21248
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Mon Jul 10 17:48:22 2017-date Mon Jul 10 17:47:40 2017 s - exit: 21248
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Mon Jul 10 17:48:41 2017-date Mon Jul 10 17:47:43 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 17:48:41 2017-date Mon Jul 10 17:47:43 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 17:48:41 2017-date Mon Jul 10 17:47:43 2017 s - exit: 21248
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Mon Jul 10 17:49:11 2017-date Mon Jul 10 17:48:15 2017 s - exit: 21248
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun2016 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun2016_MC.root : FAILED - time: date Mon Jul 10 17:50:09 2017-date Mon Jul 10 17:48:30 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun2016.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 17:50:09 2017-date Mon Jul 10 17:48:30 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun2016,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun2016 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun2016_MC.root --fileout file:RelVal_Raw_GRun2016_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 17:50:09 2017-date Mon Jul 10 17:48:30 2017 s - exit: 21248
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Mon Jul 10 17:51:14 2017-date Mon Jul 10 17:49:20 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 17:51:14 2017-date Mon Jul 10 17:49:20 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 17:51:14 2017-date Mon Jul 10 17:49:20 2017 s - exit: 21248
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Mon Jul 10 17:58:30 2017-date Mon Jul 10 17:56:46 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-09-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 17:58:30 2017-date Mon Jul 10 17:56:46 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 17:58:30 2017-date Mon Jul 10 17:56:46 2017 s - exit: 21248

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0619998
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19509/21305/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19509/21305/git-merge-result

cmsbuild · 2017-07-10T16:21:33Z

Comparison job queued.

cmsbuild · 2017-07-10T19:12:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19509/21305/summary.html

Comparison Summary:

You potentially added 3 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1884334
DQMHistoTests: Total failures: 14537
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1869631
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

slava77 · 2017-07-11T01:23:00Z

+1

for #19509 15490d4

technical/cosmetic update since the last signoff https://github.com/cms-sw/cmssw/pull/19509/files/ec539c00a4ac2798ccb458d9d2afcca66a1e090c..15490d417c7f4ad33378f4769ba3f5c821db2728?w=1
jenkins tests pass and comparisons show no differences

arizzi · 2017-07-11T13:25:59Z

I do not understand the errors, seem unrelated to me.

slava77 · 2017-07-11T13:29:50Z

On 7/11/17 9:26 AM, arizzi wrote: I do not understand the errors, seem unrelated to me.

the addOn error is unrelated to this PR and is now fixed in IB

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19509 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbnwPwr5ZiKK2aVsqMF_ag9s926kdks5sM3fpgaJpZM4OL5Vs>.

davidlange6 · 2017-07-11T14:55:48Z

merge

slava77 · 2022-09-16T13:32:51Z

DataFormats/PatCandidates/interface/PackedCandidate.h

@@ -716,6 +724,8 @@ namespace pat {
        lostInnerHitsMask = 0x30, lostInnerHitsShift=4,
        muonFlagsMask = 0x0600, muonFlagsShift=9
    };
+  public:
+    uint16_t firstHit_;


it looks like I missed that this was added as a public member in the initial review.
@cms-sw/core-l2 is it safe to change this to private or would the schema evolution/root have problems with bw compatibility?

Dr15Jones · 2022-09-16T13:39:06Z

it looks like I missed that this was added as a public member in the initial review.
https://github.com/orgs/cms-sw/teams/core-l2 is it safe to change this to private or would the schema evolution/root have problems with bw compatibility?

I think it would be OK. @pcanal what is your thoughts?

cmsbuild · 2022-09-16T13:43:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-19509/32128

pcanal · 2022-09-16T14:39:20Z

The accessibility of a data member does not affect in any way the I/O. So it is safe to change it to private.

slava77 · 2022-09-16T14:52:08Z

The accessibility of a data member does not affect in any way the I/O. So it is safe to change it to private.

great, I made a PR #39423 ; we'll see what the bot shows in the test results

arizzi added 2 commits June 30, 2017 14:44

Add first hit det/layer to PackedCandidate

f05e784

add accessor in hitpatter/trackbase, move to uint16_t, update packed …

39978ff

…producer

cmsbuild added this to the CMSSW_9_3_X milestone Jul 3, 2017

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 3, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 3, 2017

cmsbuild added tests-rejected and removed tests-started labels Jul 3, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 3, 2017

fix logic when keeping validHitInFirstPixelBarrelLayer in the quality

2353226

arizzi force-pushed the firstHit branch from 93227d0 to 2353226 Compare July 4, 2017 12:15

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels Jul 4, 2017

cmsbuild added the tests-started label Jul 10, 2017

cmsbuild added tests-rejected and removed tests-started labels Jul 10, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 10, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 11, 2017

cmsbuild merged commit 5e07685 into cms-sw:master Jul 11, 2017

arizzi mentioned this pull request Aug 3, 2017

Add first hit from HitPattern in PackedCandidates with high level track details (92X version) #20038

Closed

arizzi deleted the firstHit branch October 11, 2017 08:55

slava77 reviewed Sep 16, 2022

View reviewed changes

cmsbuild added code-checks-pending fully-signed orp-approved and removed analysis-pending pending-signatures orp-pending labels Sep 16, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add first hit from HitPattern in PackedCandidates with high level track details #19509

Add first hit from HitPattern in PackedCandidates with high level track details #19509

arizzi commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

perrotta commented Jul 3, 2017

cmsbuild commented Jul 3, 2017 •

edited

arizzi commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

arizzi commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

slava77 commented Jul 11, 2017

arizzi commented Jul 11, 2017

slava77 commented Jul 11, 2017 via email

davidlange6 commented Jul 11, 2017

slava77 Sep 16, 2022

Dr15Jones commented Sep 16, 2022

cmsbuild commented Sep 16, 2022

pcanal commented Sep 16, 2022

slava77 commented Sep 16, 2022

Add first hit from HitPattern in PackedCandidates with high level track details #19509

Add first hit from HitPattern in PackedCandidates with high level track details #19509

Conversation

arizzi commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

perrotta commented Jul 3, 2017

cmsbuild commented Jul 3, 2017 • edited

arizzi commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

arizzi commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

slava77 commented Jul 11, 2017

arizzi commented Jul 11, 2017

slava77 commented Jul 11, 2017 via email

davidlange6 commented Jul 11, 2017

slava77 Sep 16, 2022

Choose a reason for hiding this comment

Dr15Jones commented Sep 16, 2022

cmsbuild commented Sep 16, 2022

pcanal commented Sep 16, 2022

slava77 commented Sep 16, 2022

cmsbuild commented Jul 3, 2017 •

edited