Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming collision between locally defined function and variable phi. #1952

Merged
merged 1 commit into from Jan 9, 2014
Merged

Fix naming collision between locally defined function and variable phi. #1952

merged 1 commit into from Jan 9, 2014

Conversation

vkuznet
Copy link
Contributor

@vkuznet vkuznet commented Jan 6, 2014

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2014

A new Pull Request was created by @vkuznet (Valentin Kuznetsov) for CMSSW_7_0_X.

Fix naming collision between locally defined function and variable phi.

It involves the following packages:

RecoPixelVertexing/PixelTrackFitting

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2014

@ktf
Copy link
Contributor

ktf commented Jan 9, 2014

@slava77 @anton-a I'll merge this bypassing your signature. Shout if not ok.

ktf added a commit that referenced this pull request Jan 9, 2014
Fix naming collision between locally defined function and variable phi.
@ktf ktf merged commit a83fbff into cms-sw:CMSSW_7_0_X Jan 9, 2014
@slava77
Copy link
Contributor

slava77 commented Jan 9, 2014

+1
(postfactum)

based on jenkins tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants