Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hepmc port to 9x #19523

Merged
merged 6 commits into from Jul 7, 2017
Merged

Hepmc port to 9x #19523

merged 6 commits into from Jul 7, 2017

Conversation

amarini
Copy link
Contributor

@amarini amarini commented Jul 3, 2017

This is a Port of #18917 to master (9X).
Port have been tested in CMSSW_9_2_4 (HepMC->GEN, GEN->SIM)

@perrozzi

@amarini
Copy link
Contributor Author

amarini commented Jul 3, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

A new Pull Request was created by @amarini (Andrea Marini) for master.

It involves the following packages:

IOMC/Input
SimG4Core/Application

@smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Jul 4, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21132/console Started: 2017/07/04 15:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19523/21132/summary.html

Comparison Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1756063
  • DQMHistoTests: Total failures: 89
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1755808
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@civanch
Copy link
Contributor

civanch commented Jul 4, 2017

+1

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7c04e1c into cms-sw:master Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants